use internal relpath instead of os.path.relpath

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jeff Hammel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
https://github.com/mozilla/mozbase/blob/master/manifestdestiny/manifestparser/manifestparser.py#L444

However, as noted in
https://github.com/mozilla/mozbase/blob/master/manifestdestiny/manifestparser/manifestparser.py#L31

"we need relpath, but it is introduced in python 2.6"

However, we fail to use our own implementation.  We should use our
internal relpath vs os.path.relpath
(Reporter)

Comment 1

6 years ago
Created attachment 659756 [details] [diff] [review]
use internal relpath vs os.path.relpath
Attachment #659756 - Flags: review?(wlachance)
Comment on attachment 659756 [details] [diff] [review]
use internal relpath vs os.path.relpath

LGTM
Attachment #659756 - Flags: review?(wlachance) → review+
(Reporter)

Comment 3

6 years ago
pushed: https://github.com/mozilla/mozbase/commit/2e486dfcb0207cf1a2c599d4e752281861eccfde
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Blocks: 788842
(Reporter)

Updated

6 years ago
Blocks: 790018
You need to log in before you can comment on or make changes to this bug.