790009 - Clear search field on new search

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Maria Sandberg [:mushi]]

Steps to reproduce:
1. Go to https://marketplace.mozilla.org/
2. Search for "games"
3. Go back to homescreen.
4. Try to search again - last search term is shown in search field. 

Expected behavior:
Search field is cleared on new search. In the future we might add in search history in autocomplete.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Also related, the search box also used to be focused when you would click the magnifying glass. Not sure when that changed.

Comment 2

[Matt Basta [:basta]]

If you give focus to the search box when the magnifying glass is clicked, it won't show the placeholder text. Are you ok with that?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Matt Basta [:basta] from comment #2)
> If you give focus to the search box when the magnifying glass is clicked, it
> won't show the placeholder text. Are you ok with that?

No, this is beyond placeholder text. This is about new searches.

Comment 4

[Matt Basta [:basta]]

I mean if the user presses the magnifying glass, it won't say "Search" in the search box because it has focus and focus clears that placeholder text out.

Presumably, we could use different placeholder code that shows the placeholder text until the user types something, but I'd imagine that would require some significant changes (enough to call for its own bug).

If you're cool with the search box not saying "Search" before the user types, though, this is just a one-line addition.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Basta, are you following the STR in comment 0? You seem to be talking about something different.

Comment 6

[Matt Basta [:basta]]

Yeah, that's fixed. What I'm talking about is what you mentioned in comment 1.

Comment 7

[Maria Sandberg [:mushi]]

(In reply to Matt Basta [:basta] from comment #4)
> I mean if the user presses the magnifying glass, it won't say "Search" in
> the search box because it has focus and focus clears that placeholder text
> out.
 
That's fine. We don't need the placeholder text when a user is starting to search. 

> If you're cool with the search box not saying "Search" before the user
> types, though, this is just a one-line addition.

Go for it - gotta love those one-liners.

Comment 8

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/zamboni/commit/0397bffc02d47e32839a7fd00845a7a836f42df1

Comment 9

[Victor Carciu]

Verified as fixed : http://screencast.com/t/LadNt8zMKa