Lightning/Thunderbird build is broken after Bug 789382

RESOLVED FIXED in 2.0

Status

Calendar
Lightning Only
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ojab, Assigned: Stefan Sitter)

Tracking

Lightning 2.0
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
/sources/comm-central/calendar/base/src/calUtils.cpp: In function ‘nsresult cal::logError(const PRUnichar*)’:
/sources/comm-central/calendar/base/src/calUtils.cpp:19:94: error: no matching function for call to ‘nsIScriptError::Init(const PRUnichar*&, NULL, NULL, int, int, nsIScriptError::<anonymous enum>, const char [9])’
/sources/comm-central/calendar/base/src/calUtils.cpp:19:94: note: candidate is:
In file included from /sources/comm-central/calendar/base/src/calUtils.cpp:5:0:
../../../mozilla/dist/include/nsIScriptError.h:72:14: note: virtual nsresult nsIScriptError::Init(const nsAString&, const nsAString&, const nsAString&, uint32_t, uint32_t, uint32_t, const char*)
../../../mozilla/dist/include/nsIScriptError.h:72:14: note:   no known conversion for argument 1 from ‘const PRUnichar* {aka const short unsigned int*}’ to ‘const nsAString&’
/sources/comm-central/calendar/base/src/calUtils.cpp: In function ‘nsresult cal::logWarning(const PRUnichar*)’:
/sources/comm-central/calendar/base/src/calUtils.cpp:27:96: error: no matching function for call to ‘nsIScriptError::Init(const PRUnichar*&, NULL, NULL, int, int, nsIScriptError::<anonymous enum>, const char [9])’
/sources/comm-central/calendar/base/src/calUtils.cpp:27:96: note: candidate is:
In file included from /sources/comm-central/calendar/base/src/calUtils.cpp:5:0:
../../../mozilla/dist/include/nsIScriptError.h:72:14: note: virtual nsresult nsIScriptError::Init(const nsAString&, const nsAString&, const nsAString&, uint32_t, uint32_t, uint32_t, const char*)
../../../mozilla/dist/include/nsIScriptError.h:72:14: note:   no known conversion for argument 1 from ‘const PRUnichar* {aka const short unsigned int*}’ to ‘const nsAString&’
make[8]: *** [calUtils.o] Error 1
(Reporter)

Updated

5 years ago
Blocks: 789382

Updated

5 years ago
Status: UNCONFIRMED → NEW
Component: General → Lightning Only
Ever confirmed: true
OS: Linux → All
Product: Thunderbird → Calendar
Hardware: x86_64 → All

Updated

5 years ago
No longer blocks: 789382
Depends on: 790157

Updated

5 years ago
Summary: Thunderbird build is broken after Bug 789382 → Lightning/Thunderbird build is broken after Bug 789382
Conveniently, the bustage here is limited to the file in comment 0 (calUtils)

That has the only instances of "scripterror" in comm-central's cpp files on MXR:
 https://mxr.mozilla.org/comm-central/search?string=scripterror&find=cpp%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
(ignoring /mozilla subdir which appears to be straight m-c)
(Assignee)

Updated

5 years ago
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Version: Trunk → Lightning 2.0
Created attachment 660134 [details] [diff] [review]
possible untested fix

For reference, here's a fix I'd spun up (hadn't attached it yet because I didn't yet have a comm-central build & couldn't test it).

Stefan: feel free to take this and run with it -- maybe you've already generated something similar yourself. :)
Duplicate of this bug: 790157
Depends on: 789382
(Assignee)

Comment 4

5 years ago
Created attachment 660140 [details] [diff] [review]
bustage fix
Attachment #660134 - Attachment is obsolete: true
Attachment #660140 - Flags: review?(philipp)
(bustage fix looks good to me, FWIW! Thanks, and sorry for causing the bustage.)

Comment 6

5 years ago
Comment on attachment 660140 [details] [diff] [review]
bustage fix

This patch allows my build to complete and no obvious errors on startup.
Attachment #660140 - Flags: feedback+
(Assignee)

Comment 7

5 years ago
Comment on attachment 660140 [details] [diff] [review]
bustage fix

It seem that Philipp is not available at the moment. I therefore set r+ myself based on the positive feedback above to check in the bustage fix.
Attachment #660140 - Flags: review?(philipp) → review+
(Assignee)

Comment 8

5 years ago
Pushed to https://hg.mozilla.org/comm-central/rev/6d5b06e82381
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.