790117 - JavaScript functions to control external profilers should be in js/src/builtin

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

When configured correctly, the JavaScript shell includes a number of functions to control external profilers like valgrind, perf, Shark, and VTune. These are currently in js/src/jsdbgapi.cpp, but it seems like they would fit better in their own file in js/src/builtin, perhaps Profilers.cpp.

Comment 1

[Jim Blandy :jimb]

Build-only try push (I expect failures): 
https://tbpl.mozilla.org/?tree=Try&rev=3af6947410f9

Comment 2

[Jim Blandy :jimb]

Attachment: Move external profiler control functions to their own source file in js/src/builtin.

Comment 3

[Jim Blandy :jimb]

Try: https://tbpl.mozilla.org/?tree=Try&rev=d333a752eec2

Comment 4

[Jim Blandy :jimb]

Those Mac failures are unfiled, and persistent, but I don't believe they're really caused by this patch. Trying again with a fresh M-C pull before I dig in.
https://tbpl.mozilla.org/?tree=Try&rev=6190219fd52d

Comment 5

[Jim Blandy :jimb]

They're green.

Comment 6

[Jim Blandy :jimb]

Attachment: XPCOM test harness: Delete unused profiler control functions.

These functions are entirely unused, but we also now have
JS_DefineProfilingFunctions, present in both browser and JavaScript shell,
for doing what these functions were presumably intended for.

Comment 7

[Jim Blandy :jimb]

Attachment: Move external profiler control functions to their own source file in js/src/builtin; drop VTune.

The VTune support needed to be updated for changes to the VTune control API; that work is bug 675098.

Comment 8

[Steve Fink [:sfink] [:s:]]

Comment on attachment 662250 [details] [diff] [review]
Move external profiler control functions to their own source file in js/src/builtin; drop VTune.

Review of attachment 662250 [details] [diff] [review]:
-----------------------------------------------------------------

The code is a little blecherous, but I'm happy to have it hidden under a shinier rock.

Comment 9

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87bcca77b857
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fd36867bac7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87bcca77b857
https://hg.mozilla.org/mozilla-central/rev/6fd36867bac7