790136 - [b2g-bluetooth] Register HFP_AG/HSP_AG services

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

In order to tell other Bluetooth devices that we support HFP/HSP, we need to register HFP_AG/HSP_AG in SDP database.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: Added missing service UUIDs

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v1: should call StopInternal() before really turning off Bluetooth

BluetoothDBusService::StopInternal() should be called before really turning down Bluetooth, otherwise actions like RemoveReservedServices wouldn't be able to executed because bluetoothd was already killed after StartStopBluetooth(false).

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 3: v1: Registered/Unregistered HFP_AG/HSP_AG services

Services are registered after adapter path is created. Services are unregistered before shutdown Bluetooth. I kept the adapterPath as a static nsString for unregistering use and updated it whenever we got adapteradded event.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 660303 [details] [diff] [review]
patch 3: v1: Registered/Unregistered HFP_AG/HSP_AG services

Review of attachment 660303 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +568,5 @@
> +
> +  uuids.AppendElement((uint32_t)(BluetoothServiceUuid::HandsfreeAG >> 32));
> +  uuids.AppendElement((uint32_t)(BluetoothServiceUuid::HeadsetAG >> 32));
> +
> +  BluetoothService* bs = BluetoothService::Get();

Nit: Might want to try to get service before building the uuids, just to save some work.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 3: v2: Registered/Unregistered HFP_AG/HSP_AG services, r=qdot

Nit picked

Comment 6

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=c08adbbe2c90

Comment 7

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/191e77d35ca5
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d50672b64b4
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3c8270cfefe

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/191e77d35ca5
https://hg.mozilla.org/mozilla-central/rev/0d50672b64b4
https://hg.mozilla.org/mozilla-central/rev/e3c8270cfefe