790165 - Crash at pt_Write + 84 (ptio.c:1315) during shutdown when I'm logging on Mac

Status: RESOLVED INCOMPLETE

(NSPR :: NSPR, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When I'm logging on Mac, debug build always crashes at shutdown.

I did:

> export NSPR_LOG_FILE=fx.log && export NSPR_LOG_MODULES=TextInputHandlerWidgets:1
> <path-to-firefox-debug-build>/Contents/MacOS/firefox

And then, just pressed Cmd+Q.

[ChildView validAttributesForMarkedText] is called during shutdown. However, mTextInputHandler is always NULL at that time. Therefore, NS_ENSURE_TRUE() tries to put log for that. However, it causes this crash.

the crash report by OS:

> Process:         firefox [81923]
> Path:            /Volumes/VOLUME/*/NightlyDebug.app/Contents/MacOS/firefox
> Identifier:      org.mozilla.nightlydebug
> Version:         18.0a1 (1812.9.11)
> Code Type:       X86-64 (Native)
> Parent Process:  bash [72380]
> 
> Date/Time:       2012-09-11 15:35:56.477 +0900
> OS Version:      Mac OS X 10.7.4 (11E53)
> Report Version:  9
> 
> Interval Since Last Report:          70479 sec
> Crashes Since Last Report:           4
> Per-App Interval Since Last Report:  452 sec
> Per-App Crashes Since Last Report:   1
> Anonymous UUID:                      F1E5A49F-C885-4A30-B159-D8A72250B21E
> 
> Crashed Thread:  0  Dispatch queue: com.apple.main-thread
> 
> Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
> Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000
> 
> VM Regions Near 0:
> --> 
>     __TEXT                 0000000100000000-0000000100008000 [   32K] r-x/rwx SM=COW  /Volumes/VOLUME/*/NightlyDebug.app/Contents/MacOS/firefox
> 
> Application Specific Information:
> objc[81923]: garbage collection is OFF
> 
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0   XUL                           	0x00000001033b9e3f (anonymous namespace)::ValidWriteAssert(bool) + 63 (mozPoisonWriteMac.cpp:54)
> 1   XUL                           	0x00000001033b9cf4 (anonymous namespace)::AbortOnBadWrite(int, void const*, unsigned long) + 724 (mozPoisonWriteMac.cpp:283)
> 2   XUL                           	0x00000001033ba403 _ZN12_GLOBAL__N_115wrap_write_tempILZNS_10write_dataEEEEliPKvm + 35 (mozPoisonWriteMac.cpp:170)
> 3   libnspr4.dylib                	0x0000000100435754 pt_Write + 84 (ptio.c:1315)
> 4   libnspr4.dylib                	0x0000000100404d36 PR_Write + 54 (priometh.c:114)
> 5   libnspr4.dylib                	0x0000000100408860 PR_LogFlush + 112 (prlog.c:531)
> 6   libnspr4.dylib                	0x0000000100409144 PR_LogPrint + 1684 (prlog.c:522)
> 7   XUL                           	0x000000010344ad2e NS_DebugBreak_P + 702 (nsDebugImpl.cpp:342)
> 8   XUL                           	0x0000000102e68fee -[ChildView validAttributesForMarkedText] + 94 (nsChildView.mm:3946)
> 9   com.apple.AppKit              	0x00007fff8c8728f5 -[NSTextInputContext validAttributesForMarkedText] + 29
> 10  com.apple.AppKit              	0x00007fff8c872461 -[NSTextInputContext initWithClient:] + 160
> 11  com.apple.AppKit              	0x00007fff8c8723a7 +[NSTextInputContext inputContextWithClient:] + 52
> 12  com.apple.AppKit              	0x00007fff8c6ce4b2 -[NSView inputContext] + 198
> 13  XUL                           	0x0000000102e6914e -[ChildView inputContext] + 142 (nsChildView.mm:3960)
> 14  com.apple.AppKit              	0x00007fff8c775371 -[NSView _setWindow:] + 854
> 15  com.apple.AppKit              	0x00007fff8c6a3ac8 __NSViewRecursionHelper + 25
> 16  com.apple.CoreFoundation      	0x00007fff8b7e0cb4 CFArrayApplyFunction + 68
> 17  com.apple.AppKit              	0x00007fff8c775a3e -[NSView _setWindow:] + 2595
> 18  com.apple.AppKit              	0x00007fff8c6a3ac8 __NSViewRecursionHelper + 25
> 19  com.apple.CoreFoundation      	0x00007fff8b7e0cb4 CFArrayApplyFunction + 68
> 20  com.apple.AppKit              	0x00007fff8c775a3e -[NSView _setWindow:] + 2595
> 21  com.apple.AppKit              	0x00007fff8c89a37f -[NSWindow dealloc] + 1262
> 22  XUL                           	0x0000000102e544c4 -[BaseWindow dealloc] + 148 (nsCocoaWindow.mm:2258)
> 23  com.apple.AppKit              	0x00007fff8c69d00d -[NSWindow release] + 535
> 24  libobjc.A.dylib               	0x00007fff82dfa03c (anonymous namespace)::AutoreleasePoolPage::pop(void*) + 434
> 25  com.apple.CoreFoundation      	0x00007fff8b7e0915 _CFAutoreleasePoolPop + 37
> 26  com.apple.Foundation          	0x00007fff869394f9 -[NSAutoreleasePool release] + 154
> 27  XUL                           	0x00000001011afdb3 mozilla::MacAutoreleasePool::~MacAutoreleasePool() + 35 (MacAutoreleasePool.mm:20)
> 28  XUL                           	0x00000001011afd85 mozilla::MacAutoreleasePool::~MacAutoreleasePool() + 21 (MacAutoreleasePool.mm:20)
> 29  XUL                           	0x000000010118264f ScopedXPCOMStartup::~ScopedXPCOMStartup() + 239 (nsAppRunner.cpp:1116)
> 30  XUL                           	0x0000000101182555 ScopedXPCOMStartup::~ScopedXPCOMStartup() + 21 (nsAppRunner.cpp:1116)
> 31  XUL                           	0x000000010118a2f1 XREMain::XRE_main(int, char**, nsXREAppData const*) + 721 (nsAppRunner.cpp:3934)
> 32  XUL                           	0x000000010118a66f XRE_main + 63 (nsAppRunner.cpp:3988)
> 33  org.mozilla.nightlydebug      	0x0000000100001ebc _ZL7do_mainiPPc + 860 (nsBrowserApp.cpp:174)
> 34  org.mozilla.nightlydebug      	0x0000000100001785 main + 613 (nsBrowserApp.cpp:279)
> 35  org.mozilla.nightlydebug      	0x00000001000010e4 start + 52

Comment 1

[Steven Michaud [:smichaud] (Retired)]

This is weird.

I wonder if the following would work:

NS_ENSURE_TRUE(mTextInputHandler != nil, [NSArray array]);

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months and this bug has severity 'critical'.
:KaiE, could you have a look please?
For more information, please visit auto_nag documentation.