Created attachment 660019 [details] [diff] [review] The fix (diff -w) Since bug 787743 landed, we're seeing permanent hangs on aurora and beta channels for Thunderbird: TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_bug248970_cache.js | running test ... command timed out: 1200 seconds without output, attempting to kill This is due to the private browsing service not being defined. I think this is because the test changed a bit between landing and backout, and the backout didn't fully take account of this.
Attachment #660019 - Flags: review?(ehsan)
Thank you and sorry :(
Comment on attachment 660019 [details] [diff] [review] The fix (diff -w) Who says I can't make embarrassing mistakes? Just point them to this bug! :-) Thanks for fixing this.
Attachment #660019 - Flags: review?(ehsan) → review+
Comment on attachment 660021 [details] [diff] [review] The fix (full patch) [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 787743 User impact if declined: None Testing completed (on m-c, etc.): None, test-only change Risk to taking this patch (and alternatives if risky): None, test-only String or UUID changes made by this patch: None This fixes test-only bustage for gecko apps that don't have private browsing enabled.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-firefox16: --- → fixed
status-firefox17: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.