Closed
Bug 790181
Opened 12 years ago
Closed 12 years ago
Permanent orange: test_bug248970_cache.js hangs without private browsing enabled on aurora and beta
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
801 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
2.57 KB,
patch
|
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Since bug 787743 landed, we're seeing permanent hangs on aurora and beta channels for Thunderbird:
TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_bug248970_cache.js | running test ...
command timed out: 1200 seconds without output, attempting to kill
This is due to the private browsing service not being defined. I think this is because the test changed a bit between landing and backout, and the backout didn't fully take account of this.
Attachment #660019 -
Flags: review?(ehsan)
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Whiteboard: [tb-orange]
Comment 2•12 years ago
|
||
Thank you and sorry :(
Comment 3•12 years ago
|
||
Comment on attachment 660019 [details] [diff] [review]
The fix (diff -w)
Who says I can't make embarrassing mistakes? Just point them to this bug! :-)
Thanks for fixing this.
Attachment #660019 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 660021 [details] [diff] [review]
The fix (full patch)
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 787743
User impact if declined: None
Testing completed (on m-c, etc.): None, test-only change
Risk to taking this patch (and alternatives if risky): None, test-only
String or UUID changes made by this patch: None
This fixes test-only bustage for gecko apps that don't have private browsing enabled.
Attachment #660021 -
Flags: approval-mozilla-beta?
Attachment #660021 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #660021 -
Flags: approval-mozilla-beta?
Attachment #660021 -
Flags: approval-mozilla-beta+
Attachment #660021 -
Flags: approval-mozilla-aurora?
Attachment #660021 -
Flags: approval-mozilla-aurora+
Comment 5•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7bc4205a51c4
https://hg.mozilla.org/releases/mozilla-beta/rev/0211a7845cb7
Status: NEW → RESOLVED
Closed: 12 years ago
status-firefox16:
--- → fixed
status-firefox17:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [tb-orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•