790295 - Install button styling

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Maria Sandberg [:mushi]]

Steps to reproduce:
1. Search for an app or view the details page of an app.
2. Notice size of install button and text styling.

Expected behavior:
Install button should display "Free" or the app price (see bug 784561) with bolded text. Width of button 68px (or something relative that makes it take up less space).

Comment 1

[Matt Basta [:basta]]

Should this change apply to both detail pages and search results or detail pages only?

Comment 2

[Maria Sandberg [:mushi]]

(In reply to Matt Basta [:basta] from comment #1)
> Should this change apply to both detail pages and search results or detail
> pages only?

Both please :)

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Basta, I changed the text to "Free" so I think you just need to change the width. And make sure "14.99 BRL" doesn't wrap in the button.

Comment 4

[Matt Basta [:basta]]

http://cl.ly/image/2A0J2A1f3B1J

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Matt Basta [:basta] from comment #4)
> http://cl.ly/image/2A0J2A1f3B1J

What if you zoom in or charge a cool 100 BRL?

Comment 6

[Matt Basta [:basta]]

http://cl.ly/image/2d1W1T0r3V3q

Comment 7

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/zamboni/commit/9aba9254f31dd6b957d8a31fcd75b66bd91ee09b

Comment 8

[krupa raj[:krupa]]

We need more padding in the button when in "Installing.." state.

Comment 9

[Maria Sandberg [:mushi]]

(In reply to krupa raj 82[:krupa] from comment #8)
> We need more padding in the button when in "Installing.." state.

and we can also remove the ellipsis, that will help a litte.

Comment 10

[Matt Basta [:basta]]

OMG you guys are gonna love this. It's so pretty. It's almost as pretty as Krupa.

https://github.com/mozilla/zamboni/commit/17bee5de25dd136194d4da981419116306a29a3d

Comment 11

[krupa raj[:krupa]]

(In reply to Matt Basta [:basta] from comment #10)
> OMG you guys are gonna love this. It's so pretty. It's almost as pretty as
> Krupa.
> 

Flattery will get you everywhere. But, this is indeed pretty :)

Looks good on Firefox OS too.