Closed
Bug 790397
Opened 12 years ago
Closed 12 years ago
services/common/modules-testing/storageserver.js: deleted GUIDs can never be re-used
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: nalexander, Assigned: nalexander)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
3.67 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
If we PUT, DELETE, PUT, GET (or POST, DELETE, POST, GET) the same set of GUIDs, the second PUT (or POST) does not clear the internal deleted flag, meaning that the final GET fails with status code 404.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #660210 -
Flags: review?(gps)
Comment 2•12 years ago
|
||
Comment on attachment 660210 [details] [diff] [review] Patch against old m-i Review of attachment 660210 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch. Can I get some tests?
Attachment #660210 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•12 years ago
|
||
I didn't test POST because there's no existing test to steal the JSON array creation from, and I don't want to spend more time on this. I have tested POST from the Java android-sync unit tests and everything works fine.
Attachment #660210 -
Attachment is obsolete: true
Attachment #660215 -
Flags: review?(gps)
Updated•12 years ago
|
Attachment #660215 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•12 years ago
|
||
I'd check this in myself, but my m-i build is broken at the moment.
Keywords: checkin-needed
Comment 5•12 years ago
|
||
I don't land without a green Try link. https://tbpl.mozilla.org/?tree=Try&rev=91e09969f338
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #5) > I don't land without a green Try link. > https://tbpl.mozilla.org/?tree=Try&rev=91e09969f338 Good to know. Thanks!
Comment 7•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #5) > I don't land without a green Try link. > https://tbpl.mozilla.org/?tree=Try&rev=91e09969f338 I do. https://hg.mozilla.org/services/services-central/rev/7d1bd831b95d
Comment 8•12 years ago
|
||
Clearly you haven't been burned enough times by bustage then! :)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → nalexander
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d1bd831b95d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla19
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•