Closed Bug 790397 Opened 7 years ago Closed 7 years ago

services/common/modules-testing/storageserver.js: deleted GUIDs can never be re-used

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: nalexander, Assigned: nalexander)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

If we PUT, DELETE, PUT, GET (or POST, DELETE, POST, GET) the same set of GUIDs, the second PUT (or POST) does not clear the internal deleted flag, meaning that the final GET fails with status code 404.
Comment on attachment 660210 [details] [diff] [review]
Patch against old m-i

Review of attachment 660210 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Can I get some tests?
Attachment #660210 - Flags: review?(gps) → review+
I didn't test POST because there's no existing test to steal the JSON array creation from, and I don't want to spend more time on this.  I have tested POST from the Java android-sync unit tests and everything works fine.
Attachment #660210 - Attachment is obsolete: true
Attachment #660215 - Flags: review?(gps)
Attachment #660215 - Flags: review?(gps) → review+
I'd check this in myself, but my m-i build is broken at the moment.
Keywords: checkin-needed
(In reply to Ryan VanderMeulen from comment #5)
> I don't land without a green Try link.
> https://tbpl.mozilla.org/?tree=Try&rev=91e09969f338

Good to know.  Thanks!
(In reply to Ryan VanderMeulen from comment #5)
> I don't land without a green Try link.
> https://tbpl.mozilla.org/?tree=Try&rev=91e09969f338

I do.

https://hg.mozilla.org/services/services-central/rev/7d1bd831b95d
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in services][qa-]
Clearly you haven't been burned enough times by bustage then! :)
Assignee: nobody → nalexander
https://hg.mozilla.org/mozilla-central/rev/7d1bd831b95d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla19
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.