790434 - mozlog: Figure out how we are going to handle multi-process logging (cross that bridge when we get there)

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

Copying from
https://wiki.mozilla.org/Auto-tools/Projects/MozBase#Unified_Logging_-_mozlog_package
.

We'll want to be able to have unified logs from multiple processes.
This should be specced out and implemented.

Comment 1

[Andrew Halberstadt [:ahal]]

Chris, is this basically what you did earlier this week? What's the status here?

Comment 2

[Chris Manchester (limited bugmail, email directly)]

I solved the problem of interleaved log messages in runxpcshelltests.py introduced by the use of python threads in this patch for bug 887054: https://bug887054.bugzilla.mozilla.org/attachment.cgi?id=786370

I think this raises the question of whether synchronization is a problem that should be solved in mozlog itself, or whether calling code will need to solve this for its particular requirements, as in this patch, which required acquiring a lock around particular blocks of output whose logic is determined by the harness itself.

This reminds me a bit of the StringBuilder vs. StringBuffer issue in the Java standard library - I always felt is better to use a StringBuilder and do my own synchronization, as the StringBuffer commits the user to a particular granularity of locking that may not be appropriate, and can never prevent bad interleavings _between_ calls to the StringBuffer.

What is the use case that prompted this bug? Maybe there's a more general issue I'm not thinking of here.

Comment 3

[Geoff Brown [:gbrown]]

Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.