https://github.com/mozilla/mozbase/blob/master/mozlog/mozlog/logger.py#L56 def __init__(self): pass I'm guessing this can and should be removed. If there is a reason for this -- that is, if we're specifically not calling Formatter.__init__() there should be a docstring/comment explaining this (my preference is a docstring).
Created attachment 668164 [details] [diff] [review] remove
I believe there was a reason for explicitly not calling Formatter.__init__(). I'll take a look to see if I can remember it and add a docstring as explanation.
Created attachment 668186 [details] [diff] [review] Patch 1.0 - improve docstrings So this is the reason it is the way it is. Feel free to propose something different.
Attachment #668186 - Flags: review?(jhammel)
Comment on attachment 668186 [details] [diff] [review] Patch 1.0 - improve docstrings Please remove the 'pass' line. There is no reason to have a 'pass' line if you have a docstring. r+ with this change
Attachment #668186 - Flags: review?(jhammel) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.