790465 - Refactor Marionette testrunner to make Gaia testing easier

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

This patch does a couple of things:

 - it adds a console entry point for Marionette ("marionette") that allows you to run Marionette tests from anywhere; you don't need to be in the directory where runtests.py lives
 - it makes it possible to subclass the testrunner to provide a custom test class

I've already tested that these changes are harmless to current automation, and that they work for the target use case; that is, I've created a GaiaTestClass which exposes some unique methods applicable to Gaia testing, and verified I could run tests with them independent of Marionette's pre-existing test classes.  I'll submit the Gaia-related changes in a separate patch.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Refactor Marionette testrunner to make it easier to write Gaia tests,

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Refactor Marionette testrunner to make it easier to write Gaia tests,

Realized I should have bumped the version here as well

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 660251 [details] [diff] [review]
Refactor Marionette testrunner to make it easier to write Gaia tests,

Review of attachment 660251 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, thanks!

::: testing/marionette/client/marionette/marionette_test.py
@@ +52,1 @@
>      def kill_gaia_app(self, url):

We should probably remove this and kill_gaia_apps from the CommonTestCase class

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

bug 787114 was created to deal with the gaia helper functions, but I think we can change that here and close this bug

Comment 6

[Jonathan Griffin (:jgriffin)]

(In reply to Malini Das [:mdas] from comment #4)
> bug 787114 was created to deal with the gaia helper functions, but I think
> we can change that here and close this bug

I agree, I duped that bug and will remove those functions with this patch.

Comment 7

[Jonathan Griffin (:jgriffin)]

Attachment: Refactor Marionette testrunner to make it easier to write Gaia tests,

Updated patch to remove unneeded Gaia methods, pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=dc20b5313b8f

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 661383 [details] [diff] [review]
Refactor Marionette testrunner to make it easier to write Gaia tests,

Carrying r+ forward

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d96a5392ff4

Comment 10

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/8d96a5392ff4