790495 - Webapps.jsm doesn't call _registerActivities when installing a new app

Status: RESOLVED INVALID

(Core Graveyard :: DOM: Apps, defect)

Description

[Dave Hylands [:dhylands]]

I noticed that init calls _processManifestForId which in turn does:

      app.name = manifest.name;
      this._registerSystemMessages(manifest, app);
      this._registerActivities(manifest, app);

however, when installing an app (in confirmInstall) it doesn't call _registerSystemMessages anywhere.

In fact it might make sense to factor the 3 lines mentioned above into a function? Right now, it's doing

    appObject.name = app.manifest.name;

(this has to happen on appObject which the instance stored in this.webapps[id]). It isn't clear to me whether _registerSystemMessage and _registerActivities need to be called on app or whether it will work just as well on appObject.

Comment 1

[[:fabrice] Fabrice Desré]

_registerSystemMessages() is called in confirmInstall, but not _registerActivities().

I added the call in my local patch for bug 788125. I'll probably also refactor confirmInstall() when working on bug 789527.

Comment 2

[Andrew Overholt [:overholt]]

Not blocking based on comment #1 and Fabrice's other work.

Comment 3

[Dave Hylands [:dhylands]]

I wasn't sure if Fabrice had a bug already. So I'll go ahead and resolve this one.