79051 - [FIX]Allow different modes for the Add Bookmark dialog

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Fabian Guisset]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.17-21mdk i686; en-US; rv:0.9+)
Gecko/20010429
BuildID:    CVS from 01/05/05

This is taken from Ben Goodger's huge patch in bug 76502. I am splitting it into
smaller fixes. This one allows to call the addBookmark dialog with 4 different
modes (see the patch for explanations). I added a lot of comments of my own. If
you want me to remove them just say so, I'll do it no problem. Even though the
patch is mostly not by me I added my name to the contributors because I added a
few nits here and there. Again if you want me to remove it I'll do it.
This doesn't fix any bug, I think.

Reproducible: Always
Steps to Reproduce:
Three different ways of accessing the add Bookmark dialog:
1) Add Bookmarks As... menu item. Calls the default dialog.
2) New Bookmark menu item in the Bookmarks manager. Calls the dialog without the
folder picker.
3) Select a Default Bookmark Folder (bookmarks pref panel etc). Calls the dialog
without the Name and URL fields.
4) Not used yet: Calling the dialog without the "Don't ask again" checkbox.

Actual Results:  Blah

Expected Results:  Bleh

Tested extensively on Linux, but this is all XP code anyway.
Please r= and sr=, thanks.

Comment 1

[Fabian Guisset]

Attachment: Fix bug 79051. Implement modes for the add Bookmark dialog.

Comment 2

[Fabian Guisset]

Taking the bug, marking P1 mozilla0.9.1

Comment 3

[Alec Flett]

what's the comment "need to use an AddBookmark string here" - I don't quite see
how that fits in with the rest of things - you mean instead of the "OK" button?

Comment 4

[Claudius Gayle]

IIRC there is no longer any need for (4) "Don't show this again" checkbox, 
right?(Since we have the two menuitems)

Comment 5

[Fabian Guisset]

(CC'ing Ben G., I had forgotten to do it when I assigned to myself) 
so ok I will try to answer the two questions, even though I'll admit I don't
understand them ;)
Alecf: I don't see such a comment. In any case I don't think replacing the OK
button with a Add Bookmark button would be accepted. I went through the patch
again 3 times and couldn't find the relevant paragraph.

Claudius: I don't know, I'd have to check that with Ben G., but he designed it
that way (probably because his full patch removed one of the two menuitems). I
think it could also be useful for future use of the dialog (like kiosks mode).

Comment 6

[Alec Flett]

This:

+    <!-- XXX - need to use an "Add Bookmark" string here -->

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Stop. This is part of a large set of changes I have related to 76502. I'm 
landing that this week. I don't want merge conflicts. Please, everyone, stay out 
of the bookmarks FE this week.

Comment 8

[Fabian Guisset]

dangit
already checked in a few of your changes, sorry :( (bug 78586, bug 71776, I
think that's all) 
the check-ins I have made are small, though (only a few lines), so you will have
no problem updating your patches.
Sorry again for any inconvenience, I thought you had kinda given up on that
patch, since there were no updates in the bug.

Comment 9

[Fabian Guisset]

Ben fixed this as part of bug 76502.

Comment 10

[Claudius Gayle]

VERIFIED Fixed.