790521 - Fullscreen state changes doesn't propagate up to parent processes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Currently you can't exit fullscreen properly on B2G. If you exit fullscreen in a web app, the parent frame doesn't exit fullscreen. i.e. see
https://github.com/mozilla-b2g/gaia/issues/4598

The problem is that HasCrossProcessParent() in nsDocument.cpp is returning false for the root document in the web app's process because its docshell->getIsBrowserElement() is returning false. Obviously we should be checking for whether the docshell is a web app as well as if its a browser element; nsIDocShell::GetIsContentBoundary() does that, and changing HasCrossProcessParent() to do that fixes this bug.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

We should propagate fullscreen state changes across process boundaries when the root document's docshell is a content boundary, rather than only when the root document's docshell is a mozbrowser. This means apps's root documents now propagate fullscreen state changes to their parent process. Previously we only propagated fullscreen state changes for mozbrowser's root documents. I'm not sure when this regressed.

Comment 2

[Dale Harvey (:daleharvey)]

I just tested this, confirm it fixes my issue in 

https://github.com/mozilla-b2g/gaia/issues/4598

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d06938893ffe

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d06938893ffe