Closed Bug 790541 Opened 7 years ago Closed 7 years ago

B2G STK: Revise implementation of sendICCEnvelopeCommand

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [LOE: S])

Attachments

(1 file)

In dom/system/gonk/ril_worker.js,
sendICCEnvelopeCommand only sends Envelope command with MENU_SELECTION,
as we're going to support other Envelope commands,
this function should be more generalized.
Assignee: nobody → allstars.chh
blocking-basecamp: --- → ?
Whiteboard: [LOE: S]
blocking-basecamp: ? → +
Yoshi, is this a basecamp blocker?
blocking-basecamp: + → ?
Whiteboard: [LOE: S] → [LOE: S][blocked-on-input Yoshi Huang]
Yes, it's needed in Brazil.
Status: NEW → ASSIGNED
Whiteboard: [LOE: S][blocked-on-input Yoshi Huang] → [LOE: S]
blocking-basecamp: ? → +
Comment on attachment 661112 [details] [diff] [review]
Patch

Hi, philikon
This is a quick patch for revising SEND_ENVELOPE_COMMMAND, 
would you help to review this ?

Thanks
Attachment #661112 - Flags: review?(philipp)
Attachment #661112 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/488d7455150a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.