Closed
Bug 790541
Opened 13 years ago
Closed 13 years ago
B2G STK: Revise implementation of sendICCEnvelopeCommand
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [LOE: S])
Attachments
(1 file)
|
2.19 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
In dom/system/gonk/ril_worker.js,
sendICCEnvelopeCommand only sends Envelope command with MENU_SELECTION,
as we're going to support other Envelope commands,
this function should be more generalized.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → allstars.chh
blocking-basecamp: --- → ?
Whiteboard: [LOE: S]
|
||
Updated•13 years ago
|
blocking-basecamp: ? → +
|
|
||
Comment 1•13 years ago
|
||
Yoshi, is this a basecamp blocker?
blocking-basecamp: + → ?
Whiteboard: [LOE: S] → [LOE: S][blocked-on-input Yoshi Huang]
|
|
Assignee | |
Comment 2•13 years ago
|
||
Yes, it's needed in Brazil.
Status: NEW → ASSIGNED
Whiteboard: [LOE: S][blocked-on-input Yoshi Huang] → [LOE: S]
|
|
||
Updated•13 years ago
|
blocking-basecamp: ? → +
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 661112 [details] [diff] [review]
Patch
Hi, philikon
This is a quick patch for revising SEND_ENVELOPE_COMMMAND,
would you help to review this ?
Thanks
Attachment #661112 -
Flags: review?(philipp)
|
||
Updated•13 years ago
|
Attachment #661112 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Target Milestone: --- → mozilla18
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•