Created attachment 660355 [details] [diff] [review] feed-parser.js.patch User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:15.0) Gecko/20100101 Firefox/15.0.1 Build ID: 20120905151427 Steps to reproduce: Following feed URL does not work anymore. There is a RSS feed of the Google Hot Trends in my News Feeds subscription list: http://www.google.com/trends/hottrends/atom/hourly This feed URL is not legitimate, invalid, or buggy, but very useful. And this URL worked well up to Thunderbird 14. Actual results: When I update the feed (File -> Get New Messages for -> Blogs & News Feeds), a following error is raised in the Error Console: Timestamp: 9/12/12 5:42:14 PM Error: linkElements is null Source File: chrome://messenger-newsblog/content/feed-parser.js Line: 597 This may be caused by the buggy URL, but we should accept various feed URLs gently. Expected results: Hourly Google Hot Trends top 10 should come! This bug will be fixed by the following patch. Enjoy!
alta88 can you look at the patch what it is trying to accomplish? And it isn't in the proper format yet. TB18 refuses to add this feed in the Subscription dialog.
Confirming on trunk: Thu Sep 13 2012 00:22:12 Error: linkElements is null Source file: chrome://messenger-newsblog/content/feed-parser.js Line: 635
Created attachment 660489 [details] [diff] [review] patch thanks kawamoto, but the patch isn't the right way to avoid the lack of check. returning/checking for null is inherent to other parsing logic. fix included. it may be a year before it's released though.
Hi alta88, thank you for the fix. It's OK for me about release date. Thanks again, Yoshihisa Kawamoto
Yoshihisa Kawamoto, please do not close the bug, the correct patch was not yet accepted and merged into Thunderbird code.
Oh, I'm sorry for that.
Comment on attachment 660489 [details] [diff] [review] patch Review of attachment 660489 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks!
See also 792657. If this is really a regression starting at TB15, would it be worth it to push into TB16/17 quickly?
Comment on attachment 660489 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: certain feed subscribes fail. Testing completed (on c-c, etc.): Risk to taking this patch (and alternatives if risky): zero.
Checked in: https://hg.mozilla.org/releases/comm-aurora/rev/dc89f93aa4f8 https://hg.mozilla.org/releases/comm-beta/rev/15773ab9a33b