Closed Bug 790556 Opened 7 years ago Closed 7 years ago

Remember last IP address for remote debugger

Categories

(DevTools :: Debugger, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 19

People

(Reporter: sole, Assigned: vporof)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.89 Safari/537.1

Steps to reproduce:

Entered the address once, debugged the device, then closed the debugger.

Later, tried to debug more, so started the process again. 


Actual results:

I found that the debugger wouldn't remember the last IP address used for debugging. Instead it always shows: http://localhost:6000/


Expected results:

The debugger should remember the last IP address, as they rarely change while you're working on something, and IP address are annoying to type in, specially if you have to keep the port but discard the rest of the address (the default 'localhost').
Component: Untriaged → General
Product: Firefox → Firefox for Android
Version: 15 Branch → unspecified
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: General → Developer Tools: Debugger
Product: Firefox for Android → Firefox
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch v1Splinter Review
To my surprise, we were already doing that in DC__prepareConnection, after showing the prompt. Even more, the prompt was actually building the host:port string using the prefs.

The silly thing is that the Prefs object had only lazy getters for these prefs, and no setters :)
Attachment #675031 - Flags: review?(past)
Depends on: 707302
Attachment #675031 - Flags: review?(past) → review+
https://hg.mozilla.org/mozilla-central/rev/275f82501a03
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 19
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.