790576 - When jumping line numbers, pressing UP/DOWN should know how to increment/decrement

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Victor Porof [:vporof][:vp]]

While doing a :n search, pressing UP would make that :n+1, DOWN :n-1
Also wrap around.

Comment 1

[Victor Porof [:vporof][:vp]]

FILTER ON PUMPKINS.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Easy peasy.
I know we also talked about implementing Accel+G and Accel+Shift+G as a way of navigating through results, to be in line with most editors, so I added these here as well.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 686087 [details] [diff] [review]
v1

Review of attachment 686087 [details] [diff] [review]:
-----------------------------------------------------------------

I like it, but it needs to do some bounds checking. As it is I can decrease the line number until it reaches 0, which is not a valid line number, and then doesn't increase again by the down arrow. Also if I keep pressing down it will go beneath the last line and keep adding empty lines to the editor. That may become useful when it stops being read-only, but it's annoying now. Adding tests for those cases would be nice, too.

r=me with those fixed.

Comment 4

[Victor Porof [:vporof][:vp]]

Right, I was planning to do that! Don't know why I forgot about it.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Addressed comments and clamped the line boundaries to 1 .. editor.getLineCount().

Comment 6

[Victor Porof [:vporof][:vp]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=61373316b732

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/f28ab5d9dcc9

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/f28ab5d9dcc9