790581 - Security Coverage: Inspect layout/generic/nsTextFrameThebes.cpp

Status: RESOLVED INCOMPLETE

(Core :: Layout: Text and Fonts, defect)

Description

[Christian Holler (:decoder)]

According to our analysis, the file layout/generic/nsTextFrameThebes.cpp has untested portions of code/functions and has been patched one or more times in the last 6 months due to security problems. The coverage data for this file (from a try run with our main test suites) is here:

http://people.mozilla.org/~choller/coverage/mc-tests-all-20120903/layout/generic/nsTextFrameThebes.cpp.gcov.html

(Assertions, warnings and errors like out-of-memory conditions or those that cannot be triggered through content should be ignored).

File-specific comments: The coverage in this file is already very high, there are only a few branches/functions that are untouched but those should be checked nevertheless. Overall there isn't too much to check here though.

Overall coverage data from this run is available here:

http://people.mozilla.org/~choller/coverage/mc-tests-all-20120903/

Please add appropriate tests and/or check the untested portions of code if it is possible and reasonable.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Per discussion with decoder, these bugs are not likely to be relevant at this point (and the reports themselves are long gone). Any further work is better suited for new bugs at this point.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would be nice if we had a maintained source of code coverage data, though.