790634 - ./manage.py compress_assets fails

Status: RESOLVED FIXED

(Input :: General, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

From a fresh git clone properly configured, do:

  $ ./manage.py collectstatic
  $ ./manage.py compress_assets


The latter has this output:

"""
To turn on cache busting, use settings.CACHEBUST_IMGS
Traceback (most recent call last):
  File "manage.py", line 27, in <module>
    manage.main()
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor/src/funfactory/funfactory/manage.py", line 143, in main
    execute_manager(current_settings)
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor/lib/python/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor/lib/python/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor/lib/python/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor/lib/python/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor-local/src/jingo-minify/jingo_minify/management/commands/compress_assets.py", line 118, in handle
    self.update_hashes()
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor-local/src/jingo-minify/jingo_minify/management/commands/compress_assets.py", line 50, in update_hashes
    f.write('BUILD_ID_CSS = "%s"' % gitid('media/css'))
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor-local/src/jingo-minify/jingo_minify/management/commands/compress_assets.py", line 40, in gitid
    id = (git.repo.Repo(os.path.join(settings.ROOT, path))
  File "/data/input-dev/src/input-dev.allizom.org/input/vendor/lib/python/git/repo.py", line 50, in __init__
    raise NoSuchPathError(epath)
git.errors.NoSuchPathError: /data/input-dev/src/input-dev.allizom.org/input/media/css
There was an error while updating. Please try again later. Aborting.
"""

I can reproduce that locally. The "media/css" directory is suspicious.

This blocks the -dev server.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

It's a bug in jingo-minify--something we missed when fixing the media vs. static thing.

https://github.com/jsocol/jingo-minify/pull/35

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Turns out Mike had already done a pull request for it:

https://github.com/jsocol/jingo-minify/pull/34

That should have landed before we closed out bug #788231.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Fixed in master in https://github.com/mozilla/fjord/commit/b24a7deab683f5bf634dd8a450636a0eb1e0be48