790654 - Add 'uses flash' checkbox to developer submission flow

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P4)

Description

[Andrew Williamson [:eviljeff]]

Add a checkbox to Step 3 of the Developer App submission flow (Edit) so the developer can indicate during submission if their app uses flash or not.

For this to be changed by the developer post-submission the current checkbox in 'Admin Settings' will need moving to a different section ('Technical Details'? 'App Details'?) also.

Having a checkbox Reviewers can change on the review page would be good also but that will be filed as a separate bug.

Comment 1

[Wil Clouser [:clouserw]]

Not a priority, but giving to you, Andy, because you're messing with the submission tools and I don't want to make conflicts.

Comment 2

[Andy McKay]

Just to note that we track if an app is using flash on the file object not the addon. Over the course of a packaged apps lifetime, it might change depending upon the file. I'll add to the submit flow and the details page, but just to let you know this will alter the latest file object.

Comment 3

[Andrew Williamson [:eviljeff]]

the 'use flash' checkbox is in the overall app details page atm, so does this need to move as well?

Comment 4

[Andy McKay]

https://github.com/mozilla/zamboni/commit/1adb7f

No, but it will flip on and off if the packaged apps gets uploaded. I was wondering if we should default the next file for an app to the same value as a previous one. If it starts out as using flash... it will stay that way until its explicitly turned off.

Comment 5

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/developers/submit/ on FF19 (Win 7)
Attaching postfix screenshot.
Closing bug.

Comment 6

[Cristian Boldan]

Attachment: postfix flash support