790703 - Security Coverage: Inspect editor/libeditor/html/nsHTMLEditRules.cpp

Status: RESOLVED INCOMPLETE

(Core :: DOM: Editor, defect)

Description

[Christian Holler (:decoder)]

According to our analysis, the file editor/libeditor/html/nsHTMLEditRules.cpp has untested portions of code/functions and has been patched one or more times in the last 6 months due to security problems. The coverage data for this file (from a try run with our main test suites) is here:

http://people.mozilla.org/~choller/coverage/mc-tests-all-20120903/editor/libeditor/html/nsHTMLEditRules.cpp.gcov.html

(Assertions, warnings and errors like out-of-memory conditions or those that cannot be triggered through content should be ignored).

File-specific comments: Several functions at the end seem to be completely untested, as well as some mid sized chunks all over the file.

Overall coverage data from this run is available here:

http://people.mozilla.org/~choller/coverage/mc-tests-all-20120903/

Please add appropriate tests and/or check the untested portions of code if it is possible and reasonable.

Comment 1

[Christian Holler (:decoder)]

ehsan already mentioned that comment 1 from bug 790699 applies here as well :)

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Per discussion with decoder, these bugs are not likely to be relevant at this point (and the reports themselves are long gone). Any further work is better suited for new bugs at this point.