790823 - test failure: Unexpected interface name in global scope: MozTimeManager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Jim Mathies [:jimm]]

This is on elm for test /tests/dom/tests/mochitest/general/test_interfaces.html, there are two failures once we merged this code in:

13211 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | Unexpected interface name in global scope: MozTimeManager
13252 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | Unexpected interface name in global scope: MozNavigatorTime

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Just a quick drive-by fix. ;) Also, I'm wondering why this error didn't show at the previous try-build: https://bugzilla.mozilla.org/show_bug.cgi?id=714358#c142?

Comment 2

[Justin Lebar (not reading bugmail)]

Indeed, I wonder the same thing.

But maybe some builds don't have a time manager?  In which case this test will fail on those platforms.  Would you mind pushing this to try?  r=me if it passes.

Comment 3

[Gene Lian (I already quit Mozilla)]

(In reply to Justin Lebar [:jlebar] from comment #2)
> Indeed, I wonder the same thing.
> 
> But maybe some builds don't have a time manager?  In which case this test
> will fail on those platforms.  Would you mind pushing this to try?  r=me if
> it passes.

Hi Justin!

The try server results applied with these changes: https://tbpl.mozilla.org/?tree=Try&rev=b81ba4c2f8f8 are all green.

Comment 4

[Justin Lebar (not reading bugmail)]

Bizarre.

Do you need me to check this in for you, or have you got it?

Comment 5

[Gene Lian (I already quit Mozilla)]

(In reply to Justin Lebar [:jlebar] from comment #4)
> Bizarre.
> 
> Do you need me to check this in for you, or have you got it?

Indeed, very weird. Anyway, everything is green now for sure. Need your help to check it in. Thanks a lot! :)

Comment 6

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62a57a4483dd

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/62a57a4483dd

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/62a57a4483dd