790834 - change "adu/byday" API in nagios check to new crashes API

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Robert Helmer [:rhelmer]]

Socorro 18 removes the old "adu/byday" URL and replaces it with a "crashes" API. 

Please change this:
http://socorro-mware-zlb.webapp.phx1.mozilla.com:80/bpapi/adu/byday/p/Firefox/v/5.0/rt/crash/os/Windows/start/2011-08-01/end/2011-08-08

To this:

http://socorro-api-dev-internal/bpapi/crashes/daily/product/Firefox/versions/17.0a2/from_date/2012-09-05/to_date/2012-09-12/date_range_type/report/os/Windows

CC'ing Adrian, maybe he can think of a more representative way to tell if it's working? Currently it looks for the string "Win" in the output.

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #0)
> Socorro 18 removes the old "adu/byday" URL and replaces it with a "crashes"
> API. 
> 
> Please change this:
> http://socorro-mware-zlb.webapp.phx1.mozilla.com:80/bpapi/adu/byday/p/
> Firefox/v/5.0/rt/crash/os/Windows/start/2011-08-01/end/2011-08-08
> 
> To this:
> 
> http://socorro-api-dev-internal/bpapi/crashes/daily/product/Firefox/versions/
> 17.0a2/from_date/2012-09-05/to_date/2012-09-12/date_range_type/report/os/
> Windows

Sorry that hostname was from me testing on dev ^

For prod it should be:
http://socorro-mware-zlb.webapp.phx1.mozilla.com:80/bpapi/crashes/daily/product/Firefox/versions/17.0a2/from_date/2012-09-05/to_date/2012-09-12/date_range_type/report/os/Windows

Comment 2

[Ashish Vijayaram [:ashish]]

Checks are updated and returned OKs.

Comment 3

[Ashish Vijayaram [:ashish]]

rhelmer/adrian: This check needs to be updated. The request in #c1 doesn't contain the string "Win":

[[e-mail]1 ~]$ curl -sq -H "Host: socorro-mware-zlb.webapp.phx1.mozilla.com" "http://sp-mware01.phx1.mozilla.com/bpapi/crashes/daily/product/Firefox/versions/17.0a2/from_date/2012-09-05/to_date/2012-09-12/date_range_type/report/os/Windows" | grep -c Win
0
[[e-mail]1 ~]$

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Sorry it seems I missed this bug. The new /crashes/daily API doesn't return the OS if it is used as a filter. 

Maybe we can grep for the product? If you're asking for Firefox results, use grep -c Firefox as that string will always be in the results (if there's any). 

I'm not sure what the nagios check goal is: are we checking that the middleware is up, or that the /crashes/daily service actually returns data? If it's the former then we should actually grep for "hits", that's in the structure of a classical response (and is always there even if the service doesn't return any actual data). 

An empty response of that service looks like this:

{
    "hits": [],
    "total": 0
}

Comment 5

[Ashish Vijayaram [:ashish]]

Adding laura to cc too.

Comment 6

[Ashish Vijayaram [:ashish]]

I sat down with laura and decided to grep for "hits" instead. I've modified the monitor accordingly:

15:32:16 < nagios-phx1> | Mon 15:32:16 PDT [139] sp-mware01.phx1.mozilla.com:socorro-mware-zlb - http string is OK: HTTP OK: HTTP/1.1 200 OK - 1548 bytes in 0.029 second response time
15:32:26 < nagios-phx1> | Mon 15:32:26 PDT [141] sp-mware03.phx1.mozilla.com:socorro-mware-zlb - http string is OK: HTTP OK: HTTP/1.1 200 OK - 1566 bytes in 0.028 second response time
15:33:16 < nagios-phx1> | Mon 15:33:16 PDT [143] sp-mware02.phx1.mozilla.com:socorro-mware-zlb - http string is OK: HTTP OK: HTTP/1.1 200 OK - 1566 bytes in 0.028 second response time