791093 - optimize and consolidate searching for the wanted ID in the pageElements array in AccountManager.js

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #577775 comment 44 +++

Mike Conley (:mconley) 2012-09-13 18:05:31 CEST 
::: mailnews/base/prefs/content/AccountManager.js
> +  // Check the new value of the server.localPath field for validity.
> +  for (let i = 0; i < pageElements.length; i++) {
Instead of iterating through the pageElements, can't you use document.getElementById, or querySelector?

There are about 3 loops like this that just look for a specific ID and then check the value of the corresponding accountValues[] and pageElements[] arrays. Let's try to consolidate this into some wrapper functions that hides the implementation details of how to find the ID and also may be faster without looping over the array, e.g. like:
top.frames["contentFrame"].document.querySelector("#server.localPath[wsm_persist='true']") ...

Comment 1

[:aceman]

Attachment: patch

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=196d40544834dbf411f910dad8647b9c172d1170

Comment 2

[:aceman]

Attachment: patch v2

Removed unrelated changes that belong in another bug.

Comment 3

[:aceman]

https://hg.mozilla.org/comm-central/rev/c23005eea70868e2031e9e0a35c389cc3b00559c