791198 - After cancelling Private Browsing, download progress in Windows 7 taskbar remains

Status: RESOLVED WONTFIX

(Firefox :: Private Browsing, defect)

Description

[david.smitmanis]

On Windows 7

To reproduce:

1. Enter Private Browsing
2. Start a download
3. Before the download finishes, cancel PB and confirm that you want to exit back to normal mode. Make sure the downloads window is up.

The Firefox icon in the taskbar will still show the download progress in yellow (for paused download). It will remain until you close the downloads window.

Comment 1

[(no longer active)]

Brian, do you know where that progress bar comes from?

Comment 2

[Brian R. Bondy [:bbondy]]

see widget\nsIWinTaskbar.idl

Comment 3

[(no longer active)]

So I think this is the code in question: http://dxr.allizom.org/mozilla-central/toolkit/mozapps/downloads/DownloadTaskbarProgress.jsm#l206

Who owns this stuff?

Comment 4

[Brian R. Bondy [:bbondy]]

well... who touched it last? :)

Comment 5

[(no longer active)]

Jim?  :-)

Comment 6

[Jim Mathies [:jimm]]

What's the proper download behavior in a case like this?

Comment 7

[Jim Mathies [:jimm]]

Looks somewhat undefined - 

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#2064

We handle pausing going and resume coming out of, but I'm not sure what we should be doing for the reverse scenario.

Comment 8

[Jim Mathies [:jimm]]

Actually maybe it's here - 

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#2041

In which case we should be confirming with the user before cancelling? I guess I'll have to step through to see.

Comment 9

[(no longer active)]

The point is that when we cancel the download, the progress bar should no longer display in the taskbar, right?

Comment 10

[Jim Mathies [:jimm]]

(In reply to Ehsan Akhgari [:ehsan] from comment #9)
> The point is that when we cancel the download, the progress bar should no
> longer display in the taskbar, right?

Assuming the download was canceled, the taskbar shouldn't reflect an active download state.

Comment 11

[(no longer active)]

(In reply to comment #10)
> (In reply to Ehsan Akhgari [:ehsan] from comment #9)
> > The point is that when we cancel the download, the progress bar should no
> > longer display in the taskbar, right?
> 
> Assuming the download was canceled, the taskbar shouldn't reflect an active
> download state.

OK, good.  Jim, do you want to take a stab at this, please?

Comment 12

[Jim Mathies [:jimm]]

Sure, I can take a look.

Comment 13

[(no longer active)]

Thanks!

Comment 14

[Rodrigo Andrade]

I am very interested in this bug. What is the right approach to fix it?

Comment 15

[Josh Matthews [:jdm]]

First step is to see whether this is still and issue with per-window private browsing enabled. Rodrigo, could you try and reproduce it?

Comment 16

[Rodrigo Andrade]

I reckon this is not an issue anymore. Since there is no longer a Download task bar, Firefox asks whether the user wants to end PBM and cancel the active downloads or not. There is no way to deactivate PBM and continue downloading. Is that right?

Comment 17

[Chris Peterson [:cpeterson]]

Resolving this bug as WONTFIX because Firefox versions >= 116 no longer support Windows 7-8.1.