Closed Bug 791266 Opened 8 years ago Closed 7 years ago

Add .CAF files (Core Audio Format) to the types of sound files selectable on OS X.

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: ewong)

Details

(Whiteboard: [good first bug][lang=js][mentor=IanN][level=beginner])

Attachments

(1 file, 1 obsolete file)

Where we need to add .caf support:

http://mxr.mozilla.org/comm-central/source/suite/common/pref/preferences.js?rev=84ac3c711098&mark=49-49,51-51#35

The equivalent Thunderbird patch is at this line:
https://hg.mozilla.org/comm-central/rev/fc2a8fd24ed1#l1.23
See TB Bug 466276 - .caf files grayed out (not selectable) in Preferences > General > Use the following sound file > Browse...

References: http://en.wikipedia.org/wiki/Core_Audio_Format
I am Ramana, a newbie. Can I work on this bug??
> I am Ramana, a newbie. Can I work on this bug??
Sure thing. First you need to be able to build SeaMonkey. Have you read https://developer.mozilla.org/en-US/docs/Simple_SeaMonkey_build ?
Also what OS are you on?
I have windows and Ubuntu I want to work on ubuntu.
In https://developer.mozilla.org/en-US/docs/Simple_SeaMonkey_build
For the section on Ubuntu instead of:
  sudo apt-get build-dep seamonkey
Use:
  sudo apt-get build-dep thunderbird
As Ubuntu has removed SeaMonkey from their distros.

Also please join us on IRC: irc://moznet/seamonkey . Another useful channel is irc://moznet/introduction where there is lots of help in getting started.
I am geting error like this

user@ubuntu:~$ sudo apt-get build-dep thunderbird
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: You must put some 'source' URIs in your sources.list

user@ubuntu:~$ sudo apt-get install mercurial libasound2-dev libcurl4-openssl-dev libnotify-dev
[sudo] password for mathnoob: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libasound2-dev : Depends: libasound2 (= 1.0.25-1ubuntu10)
 libcurl4-openssl-dev : Depends: libkrb5-dev but it is not going to be installed
                        Depends: libldap2-dev but it is not going to be installed
                        Depends: librtmp-dev but it is not going to be installed
                        Depends: libssl-dev but it is not going to be installed
 libnotify-dev : Depends: libglib2.0-dev (>= 2.26) but it is not going to be installed
                 Depends: libgdk-pixbuf2.0-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Can you please help??
Unfortunately I'm not on Linux. Can you try asking on IRC?
irc://moznet/introduction  should be a good place to start. Also
irc://moznet/seamonkey  for SeaMonkey specific build problems.
Okay Actually I kind of asked for help but I didn't any helpful advice till now.
Assignee: nobody → idlike2dream
Status: NEW → ASSIGNED
Can you tell me how to build on windows??
Hi idlike2dream@gmail.com. Are you still working on this?
Flags: needinfo?(idlike2dream)
Hey Sorry I wasn't online for quite a few months I am busy doing some other work now.
Flags: needinfo?(idlike2dream) needinfo?(idlike2dream) → needinfo-
Thanks for letting us know.
Assignee: idlike2dream → nobody
Status: ASSIGNED → NEW
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #680530 - Flags: review?(iann_bugzilla)
Comment on attachment 680530 [details] [diff] [review]
Add .CAF files to types of sound files selectable on OS X. (v1)

I think you need someone on Mac to test this patch.
Attachment #680530 - Flags: review?(stefanh)
Comment on attachment 680530 [details] [diff] [review]
Add .CAF files to types of sound files selectable on OS X. (v1)

   // On Mac, allow AIFF files too.
   if (/Mac/.test(navigator.platform))
-    filterExts += "; *.aif; *.aiff";
+    filterExts += "; *.aif; *.aiff; *.caf";

r= me if you change the comment to say "On Mac, allow AIFF and CAF files too."
Attachment #680530 - Flags: review?(stefanh) → review+
Attachment #680530 - Attachment is obsolete: true
Attachment #680530 - Flags: review?(iann_bugzilla)
Attachment #680902 - Flags: review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/3830e86091b3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.