Closed Bug 791267 Opened 11 years ago Closed 11 years ago

We can now use CPU architecture (ABI) for multiple APK filtering

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
19 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox16-, firefox17+ fixed, fennec17+)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox16 - ---
firefox17 + fixed
fennec 17+ ---

People

(Reporter: mfinkle, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

back out bug 788666
1.65 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
In bug 788666, we needed to hack ARMv7 and ARMv6 multiple APKs to use screensize as the way to make the configurations be different. Google now supports "CPU architecture (ABI)" as a way to make the configurations be different.

This should mean we can backout the hack added in bug 788666.

http://developer.android.com/guide/google/play/publishing/multiple-apks.html
What timing.. at least we can remove the hack though!
tracking-firefox16: --- → +
We'll want to test on a Google Play test product before officially making this change.
tracking-fennec: --- → ?
tracking-firefox16: + → -
Assignee: nobody → mbrubeck
tracking-fennec: ? → 17+
tracking-firefox17: --- → ?
There is a test build here:
https://play.google.com/store/apps/details?id=org.mozilla.fennec_blassey

The build has a backout of bug 788666. Can we get some QA testing to see if ARMv6 and ARMv7 works ok on that build?
Works. Tried the HTC Wildfire S, HTC Legend, LG Slider and each got an ~18MB ARMv6 build. Galaxy Nexus/Nexus 7 both got an ~17.3 MB ARMv7 build.
Note that finkle just took down the ARMv6 build in the market. Any further testing will be broken until further notice.
This has been fixed, resume testing
Blocks: 788666
Marking this as fixed for Fx17 based on comment 4.  This also means we can back out the patch from bug 788666 on trunk; leaving the bug open until that is done.
status-firefox17: --- → fixed
Revert this manifest change that we added to work around Google Play limitations.
Attachment #673430 - Flags: review?(mark.finkle)
Attachment #673430 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/eeaec0df48ee
Flags: in-testsuite-
Version: Firefox 16 → Firefox 19
https://hg.mozilla.org/mozilla-central/rev/eeaec0df48ee
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.