We can now use CPU architecture (ABI) for multiple APK filtering

RESOLVED FIXED in Firefox 17

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: mfinkle, Assigned: mbrubeck)

Tracking

19 Branch
Firefox 19
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox16-, firefox17+ fixed, fennec17+)

Details

Attachments

(1 attachment)

In bug 788666, we needed to hack ARMv7 and ARMv6 multiple APKs to use screensize as the way to make the configurations be different. Google now supports "CPU architecture (ABI)" as a way to make the configurations be different.

This should mean we can backout the hack added in bug 788666.

http://developer.android.com/guide/google/play/publishing/multiple-apks.html

Comment 1

5 years ago
What timing.. at least we can remove the hack though!
tracking-firefox16: --- → +

Comment 2

5 years ago
We'll want to test on a Google Play test product before officially making this change.

Updated

5 years ago
tracking-fennec: --- → ?
tracking-firefox16: + → -
Assignee: nobody → mbrubeck
tracking-fennec: ? → 17+
tracking-firefox17: --- → ?

Updated

5 years ago
tracking-firefox17: ? → +
There is a test build here:
https://play.google.com/store/apps/details?id=org.mozilla.fennec_blassey

The build has a backout of bug 788666. Can we get some QA testing to see if ARMv6 and ARMv7 works ok on that build?
Works. Tried the HTC Wildfire S, HTC Legend, LG Slider and each got an ~18MB ARMv6 build. Galaxy Nexus/Nexus 7 both got an ~17.3 MB ARMv7 build.
Note that finkle just took down the ARMv6 build in the market. Any further testing will be broken until further notice.
This has been fixed, resume testing
(Assignee)

Updated

5 years ago
Blocks: 788666
(Assignee)

Comment 7

5 years ago
Marking this as fixed for Fx17 based on comment 4.  This also means we can back out the patch from bug 788666 on trunk; leaving the bug open until that is done.
status-firefox17: --- → fixed
(Assignee)

Comment 8

5 years ago
Created attachment 673430 [details] [diff] [review]
back out bug 788666

Revert this manifest change that we added to work around Google Play limitations.
Attachment #673430 - Flags: review?(mark.finkle)
(Reporter)

Updated

5 years ago
Attachment #673430 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/eeaec0df48ee
Flags: in-testsuite-
Version: Firefox 16 → Firefox 19
https://hg.mozilla.org/mozilla-central/rev/eeaec0df48ee
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.