791366 - Implement memory reporters missing on BSDs

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Jan Beich]

Attachment: Bug 791366 - Define HAVE_PAGE_FAULT_REPORTERS on every Unix.

getrusage() comes from 4.2BSD and at least 4.4BSD has ru_majflt/ru_minflt. I'm not sure if there any incompatible implementations.

Comment 2

[Jan Beich]

Attachment: Bug 791366 - Implement Vsize and Resident memory reports on BSDs.

NS_SUCCEEDED is probably superfluous

Comment 3

[Jan Beich]

Attachment: test program

Comment 4

[Jan Beich]

Looking at MapsReporter some bits can be ported to struct kinfo_vmentry (only FreeBSD)

- using kve_protection for rwx flags
- using kve_path for pathname when KVME_TYPE_VNODE
- Swap is when KVME_TYPE_SWAP
- using kve_resident * pagesize for Rss
- everything besides KVME_TYPE_{VNODE,DEVICE} for Anon mappings

but others need more poking or mimicking procstat(1). Any hope on other BSDs?

Comment 5

[Justin Lebar (not reading bugmail)]

> Attachment #661434 [details] [diff] - Flags: review?([e-mail]) → review?
> ([e-mail])

This is probably wise; njn's review queue is probably less crazy than mine atm.

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 661433 [details] [diff] [review]
Bug 791366 - Define HAVE_PAGE_FAULT_REPORTERS on every Unix.

Review of attachment 661433 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok;  we can back out and try something else if it causes problems.

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 661434 [details] [diff] [review]
Bug 791366 - Implement Vsize and Resident memory reports on BSDs.

Review of attachment 661434 [details] [diff] [review]:
-----------------------------------------------------------------

I won't pretend to understand how GetKinfoProcSelf(), but that doesn't worry me because this is BSD-only code.  The rest of the patch looks fine, thanks.

Comment 8

[Nicholas Nethercote [inactive]]

(In reply to Jan Beich from comment #4)
> Looking at MapsReporter some bits can be ported to struct kinfo_vmentry
> (only FreeBSD)

TBH I wouldn't bother.  MapsReporter on Linux has provided us with very little in the way of useful information.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cdc27b83300
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fce157732f3

Comment 10

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/5cdc27b83300
https://hg.mozilla.org/mozilla-central/rev/8fce157732f3

Comment 11

[Nicholas Nethercote [inactive]]

Can this bug be closed?  All the blocking bugs are fixed.