791367 - nsDOMFileReader::ReadFileContent opens a channel without associating it with a load group

Status: RESOLVED FIXED

Description

[:Ehsan Akhgari]

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDOMFileReader.cpp#413

Boris, should we grab the global object for the JSContext, get the window out of it and go through the ugliness to get to a load group?

Comment 1

[Olli Pettay [:smaug] (high review load)]

Getting loadgroup from GetOwner()->GetExtandDoc() would be more correct.

Comment 2

[Olli Pettay [:smaug] (high review load)]

GetExtantDoc

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

What Olli said: the FileReader is associated with a window, so we should use that window's loadgroup.

Comment 4

[:Ehsan Akhgari]

Created attachment 661384 [details] [diff] [review]
Patch (v1)

Like this?

Comment 5

[Olli Pettay [:smaug] (high review load)]

Comment on attachment 661384 [details] [diff] [review]
Patch (v1)

Could you make this.

nsCOMPtr<nsILoadGroup> loadGroup;
if (HasOrHasHadOwner()) {
  NS_ENSURE_STATE(GetOwner());
  nsIDocument* doc = GetOwner()->GetExtantDoc();
  if (doc) {
    loadGroup = doc->GetDocumentLoadGroup();
  }
}
rv = NS_NewChannel(getter_AddRefs(mChannel), uri, nullptr, loadGroup);


(if we need similar thing more often, we could add a helper
method to nsDOMEventTargetHelper)

Comment 6

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Will this make FileReader spin the network activity spinner on the tab?

Comment 7

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Yes, if you're not setting the LOAD_BACKGROUND flag.  Which you probably should be.

Comment 8

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Unless you want progress notifications for it...

Comment 9

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

We don't need nsIProgressEventSink notifications, but we do need OnDataAvailable.

Comment 10

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 661384 [details] [diff] [review]
Patch (v1)

r- until you sort out the throbber stuff

Comment 11

[Boris Zbarsky [:bzbarsky, bz on IRC]]

LOAD_BACKGROUND gets OnDataAvailable; just not nsIProgressEventSink stuff.

Comment 12

[:Ehsan Akhgari]

Created attachment 661994 [details] [diff] [review]
Patch (v2)

This should address both Olli's and Kyle's concerns.

Comment 13

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 661994 [details] [diff] [review]
Patch (v2)

Review of attachment 661994 [details] [diff] [review]:
-----------------------------------------------------------------

r=me provided you've tested that this makes the spinner not spin.

Thanks for doing this.

Comment 14

[:Ehsan Akhgari]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b9ae51cb797

Comment 15

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/4b9ae51cb797