791423 - WebRTC Assertion failure: mIceState != kIceGathering, at media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:371

Status: RESOLVED INVALID

(Core :: WebRTC: Signaling, defect, P2)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

!!! Real PeerConnection constructor called OMG !!!

!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : calling initialize
!!! Queue for {b827e3b0-c1cb-d243-829e-e5ef6150aace} is currently: []
!!! Queue for {b827e3b0-c1cb-d243-829e-e5ef6150aace} is currently: []
!!! mozPeerConnection constructor called [object Window @ 0x11b6378e0 (native @ 0x11b65f0d0)]
!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : connect() called
PeerConnectionImpl::Connect()
PeerConnectionImpl::Connect() returned
PeerConnectionImpl::ConnectThread() finished
!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : connect() returned
!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : createOffer called
!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : queued createOffer
!!! Queue for {b827e3b0-c1cb-d243-829e-e5ef6150aace} is currently: [createOffer,]
!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : createOffer returned
OnMessage: mChannel 0x0 mConnection 0x10c88b850
PeerConnectionImpl:: got NotifyConnection
Delivering PeerConnection onconnection
!!! {b827e3b0-c1cb-d243-829e-e5ef6150aace} : onConnection called
!!! in executeNext: !!! Queue for {b827e3b0-c1cb-d243-829e-e5ef6150aace} is currently: [createOffer,]
Assertion failure: mIceState != kIceGathering, at /Users/cdiehl/Code/Mozilla/mc-alder/media/webrtc/signaling//./src/peerconnection/PeerConnectionImpl.h:371

Comment 1

[Christoph Diehl [:posidron]]

Attachment: callstack

Comment 2

[Christoph Diehl [:posidron]]

Attachment: testcase

The threads mixed up my fuzzing output. This is the correct testcase for the bug.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: crashtest v1

Crashtest for original testcase which seems to have been fixed meanwhile. I can't get the browser to crash anymore. But verified that it crashes with an alder nightly build from Sep 15th.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

so the reason why we do not see the crash is that mozPeerConnection has been moved to mozRTCPeerConnection and there is no connect() method available. Jesup, is this bug invalid now?

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 673108 [details] [diff] [review]
crashtest v1

Review of attachment 673108 [details] [diff] [review]:
-----------------------------------------------------------------

Given how much the API and code has changed since this bug was filed, I don't think this is a useful crashtest to continue to run.  Anything here should be covered by other basic "call basic api function" tests.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Agreed, invalid now