791441 - android.database.sqlite.SQLiteException: index bookmarks_type_deleted_index already exists: , while compiling: CREATE INDEX bookmarks_type_deleted_index ON bookmarks(type, deleted) at android.database.sqlite.SQLiteCompiledSql.native_compile(Native Method)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It has been hit by three users.
It first appeared in 17.0a2/20120914 and 18.0a1/20120913. The regression ranges might be:
http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=01054a593d3d&tochange=bd535573e384
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6e78c3efd115&tochange=f36b93c70d05
It might be caused by bug 790608, which is odd.

Here is a crash report: bp-be8658a8-8458-4ae8-a9bd-fb2b82120914.

android.database.sqlite.SQLiteException: index bookmarks_type_deleted_index already exists: , while compiling: CREATE INDEX bookmarks_type_deleted_index ON bookmarks(type, deleted)
	at android.database.sqlite.SQLiteCompiledSql.native_compile(Native Method)
	at android.database.sqlite.SQLiteCompiledSql.<init>(SQLiteCompiledSql.java:68)
	at android.database.sqlite.SQLiteProgram.compileSql(SQLiteProgram.java:134)
	at android.database.sqlite.SQLiteProgram.compileAndbindAllArgs(SQLiteProgram.java:361)
	at android.database.sqlite.SQLiteStatement.acquireAndLock(SQLiteStatement.java:260)
	at android.database.sqlite.SQLiteStatement.executeUpdateDelete(SQLiteStatement.java:84)
	at android.database.sqlite.SQLiteDatabase.executeSql(SQLiteDatabase.java:1899)
	at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1839)
	at org.mozilla.fennec.db.BrowserProvider$DatabaseHelper.upgradeDatabaseFrom10to11(BrowserProvider.java:1061)
	at org.mozilla.fennec.db.BrowserProvider$DatabaseHelper.onUpgrade(BrowserProvider.java:1115)
	at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:170)
	at org.mozilla.gecko.db.DBUtils.ensureDatabaseIsNotLocked(DBUtils.java:76)
	at org.mozilla.fennec.db.BrowserProvider.getDatabaseHelperForProfile(BrowserProvider.java:1210)
	at org.mozilla.fennec.db.BrowserProvider.getWritableDatabase(BrowserProvider.java:1260)
	at org.mozilla.fennec.db.BrowserProvider.update(BrowserProvider.java:1555)
	at android.content.ContentProvider$Transport.update(ContentProvider.java:219)
	at android.content.ContentResolver.update(ContentResolver.java:856)
	at org.mozilla.gecko.db.LocalBrowserDB.updateVisitedHistory(LocalBrowserDB.java:209)
	at org.mozilla.gecko.db.BrowserDB.updateVisitedHistory(BrowserDB.java:105)
	at org.mozilla.gecko.GlobalHistory.add(GlobalHistory.java:122)
	at org.mozilla.gecko.GeckoAppShell$16.run(GeckoAppShell.java:2014)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:31)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=android.database.sqlite.SQLiteException%3A+index+bookmarks_type_deleted_index+already+exists%3A+%2C+while+compiling%3A+CREATE+INDEX+bookmarks_type_deleted_index+ON+bookmarks%28type%2C+deleted%29+at+android.database.sqlite.SQLiteCompiledSql.native_compile%28Native+Method%29

Comment 1

[Scoobidiver (away)]

More reports also at:
https://crash-stats.mozilla.com/report/list?signature=android.database.sqlite.SQLiteException%3A+index+bookmarks_type_deleted_index+already+exists%3A+CREATE+INDEX+bookmarks_type_deleted_index+ON+bookmarks%28type%2C+deleted%29+at+android.database.sqlite.SQLiteDatabase.native_execSQL%28Native+Method%29

Comment 2

[Chris Peterson [:cpeterson]]

This SQLiteException looks like something you might be interested in.

Comment 3

[Scoobidiver (away)]

Crashes happened in 18.0a1/20120912 later. The m-c regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=96287ad60bef&tochange=6e78c3efd115
No bugs belong to both.

Comment 4

[Scoobidiver (away)]

With combined signatures, it's #6 top crasher in 17.0a2 and #5 in 18.0a1 considering crash signatures of bug 790139 as a single one.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't understand how this could be related to bug 790139, but the stack in this crash looks sane. Can you take a look Lucas?

Comment 6

[Scoobidiver (away)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> I don't understand how this could be related to bug 790139
I haven't said that. Bug 790139 takes 10 top ranks in 17.0a2 and 18.0a1 because its signature moves with each builds, so this bug is wrongly ranked. Ranks in comment 4 are an extrapolation.

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> I don't understand how this could be related to bug 790139, but the stack in
> this crash looks sane. Can you take a look Lucas?

This index has been added in bug 768268. Will have a look.

Comment 8

[Scoobidiver (away)]

It's #2 unfixed top crasher in 18.0a1.

Comment 9

[Lucas Rocha (:lucasr)]

Very strange. The index is created on an upgrade from schema version 10 to 11 or if the database is being created with version 11 from the start. There's probably some weird upgrade situation happening there. I need more specific STR in order to work on this.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Might cause upgrading issues from previous to 18?  Self note : need to keep an eye on this.

Comment 11

[Alex Keybl [:akeybl]]

(In reply to Lucas Rocha (:lucasr) from comment #9)
> Very strange. The index is created on an upgrade from schema version 10 to
> 11 or if the database is being created with version 11 from the start.
> There's probably some weird upgrade situation happening there. I need more
> specific STR in order to work on this.

We'll continue to try to reproduce in QA. There are no speculative fixes or debug info that can be added at this point?

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Kevin, any luck coming up with STR here?  Added steps-wanted in case this has fallen off the radar.  We can talk more about it at Tuesday's channel meeting.

Comment 13

[Alex Keybl [:akeybl]]

We're not seeing this on Beta/Release, only Nightly/Aurora. Kevin is guessing this may be related to the updater. Untracking regardless.

Comment 14

[Brian Nicholson (:bnicholson)]

createBookmarksTable() is called here, in migrateBookmarksTable():

http://hg.mozilla.org/integration/mozilla-inbound/file/0c3592db8b44/mobile/android/base/db/BrowserProvider.java.in#l982

migrateBookmarksTable() is called when upgrading from 1->2, 3->4, or 6->7. So I imagine this will happen whenever we try to upgrade from 10->11 after that (since we also create the index in upgradeDatabaseFrom10to11()).

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

What versions did we make this upgrade last? (FxA X -> Y)

Comment 16

[Brian Nicholson (:bnicholson)]

Bug 768268 was the 10->11 upgrade, which landed on Fx18. It was also uplifted to Fx16 and Fx17.

Comment 17

[Brian Nicholson (:bnicholson)]

Bug 739514 was 6->7, and landed in Fx14. So perhaps you can hit this bug if you try going from Fx13 (or earlier) directly to Fx16 (or later)?

Comment 18

[Scoobidiver (away)]

17.0 Beta is almost unaffected.

Comment 19

[Lucas Rocha (:lucasr)]

Yeah, this is probably another symptom of bug 794929.

Comment 21

[Scoobidiver (away)]

There are no crashes in 18.0b1.

Comment 22

[Lucas Rocha (:lucasr)]

Don't think there's any safe thing we can do in 18 here. This is most likely a bug caused by upgrades from very old versions to latest. Also, no instances of this crash in 18 so far. Untracking.

Comment 23

[Scoobidiver (away)]

There are only a few crashes.

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 25

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 26

[Chris Peterson [:cpeterson]]

Removing steps-wanted keyword because this bug has been resolved.

Comment 27

[Chris Peterson [:cpeterson]]

Removing steps-wanted keyword because this bug has been resolved.