791460 - Make ConnectionManager in ldappool more robust for default configuration

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[c.koke]

Attachment: Patch for the issue

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120806212620

Steps to reproduce:

I tried to use the user.ldap module for authentication with some default parameters:
[DEFAULT]
debug = True
profile = false

[auth]
allow_new_users = false
backend = services.user.mozilla_ldap.LDAPUser
ldapuri = ldap://localhost
use_tls = false
check_account_state = false
users_root = "ou=Users,dc=localhost"
search_root = "ou=Users,dc=localhost"
...


Actual results:

The server throwed pyhton execetion with this configuration for two reasons:
1) ConnectionManager didn't takes keyword arguments and couldn't handel the profile
2) Since no bind password is given it tries to apply encode to none

I attach a patch that fixes this issus


Expected results:

The server should handle the config ;)

Comment 1

[Ryan Kelly [:rfkelly]]

Whoops, sorry, this got buried in my inbox.  Thanks for the patch!  I've made some stylistic tweaks and committed it in http://hg.mozilla.org/services/server-core/rev/d25a4558d96b