Closed Bug 791564 Opened 12 years ago Closed 12 years ago

If no flagtype is multiplicable for a given bug, then unset flags are displayed by default instead of being hidden

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

4.3.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

Attached patch patch, v1Splinter Review
bug.flag_types.flags is always defined, even if this flag type has no flags. So we must call .size on it to get the exact number of flags to determine which UI to display to the user. Also, to determine if the "Flags" label must be displayed or not, it's not enough to check if the flagtype is active. We must also make sure that the user is allowed to edit it.

Granting myself review as module owner for flags.
Attachment #661616 - Flags: review+
Flags: blocking4.4+
Flags: approval4.4+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/bug/edit.html.tmpl
Committed revision 8392.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified template/en/default/bug/edit.html.tmpl
Committed revision 8389.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: