791737 - there is no graph for hangs in the crashes per daily user view

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[juan becerra [:juanb]]

There is no graph when you select "hangs" in the crashes per user page.

Steps:
1. Go to crash-stats and select Crashes per User
2. Select to see only the hangs

Expected:
1. Pretty graph with hangs per branch

Actual: There is no graph

Comment 1

[Laura Thomson :laura]

Juan: is this for nightly or aurora?  If so, probably due to bsmedberg's experiments (hangs are no longer coming in to Socorro).

Can somebody take a look please?

Comment 2

[Robert Helmer [:rhelmer]]

I see this too, mware URL is:

/bpapi/crashes/daily/product/Firefox/versions/18.0a1%2B17.0a2%2B16.0b3%2B15.0.1/from_date/2012-09-02/to_date/2012-09-16/date_range_type/report/os/Windows%2BMac%20OS%20X%2BLinux/report_type/hang/

I'll dig up the SQL it's using.

Comment 3

[Robert Helmer [:rhelmer]]

/* socorro.external.postgresql.crashes.Crashes.get_daily */ 
SELECT product_name, version_string, report_date, 
       sum(adjusted_report_count)::bigint as report_count, sum(adu)::bigint as adu,    
       crash_hadu(sum(report_count)::bigint, sum(adu)::bigint, 
       avg(throttle)) as crash_hadu, 
       avg(throttle) as throttle 
FROM ( SELECT product_name, version_string, report_date, os_name, os_short_name, 
              SUM(report_count)::int as report_count, 
              SUM(adjusted_report_count)::int as adjusted_report_count,
              MAX(adu) as adu, AVG(throttle) as throttle 
       FROM crashes_by_user_view 
       WHERE product_name=E'Firefox' 
           AND version_string IN (E'18.0a1', E'17.0a2', E'16.0b3', E'15.0.1') 
           AND report_date BETWEEN E'2012-09-02' 
           AND E'2012-09-16' 
           AND os_short_name IN (E'win', E'mac', E'lin') 
           AND crash_type_short IN (E'hang') 
       GROUP BY product_name, version_string, report_date, os_name, os_short_name ) as aggregated_crashes_by_user 
       GROUP BY product_name, version_string, report_date

Comment 4

[Robert Helmer [:rhelmer]]

I looked at the data here, apparently crash_type_short has values like "hang-b" and "hang-p".

Comment 5

[Robert Helmer [:rhelmer]]

Looks like this is an intentional change, hang-b and hang-p are for browser and plugin hangs respectively:

https://github.com/mozilla/socorro/blob/master/sql/upgrade/18.0/crash_by_user.sql#L21

Looks like we don't have UI for this so I propose we change the SQL to be:

AND crash_type_short IN (E'hang-b', E'hang-p')

Comment 6

[Robert Helmer [:rhelmer]]

Schalk is working on this.

Comment 7

[Robert Helmer [:rhelmer]]

Juan, how urgent is this? Can it wait until Wednesday or does it need a fix ASAP ?

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #7)
> Juan, how urgent is this? Can it wait until Wednesday or does it need a fix
> ASAP ?

Actually nevermind, we are shipping some regression fixes today, this can go along with that.

Comment 9

[juan becerra [:juanb]]

It's not urgent, but if it can ride the next train, yay!

Comment 10

[Schalk Neethling [:espressive]]

Pull request sent :: https://github.com/mozilla/socorro/pull/826

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9ee45c57b1d9e1abc576f66205c4cedd7d0435fa
added options to choose browser hang or plugin hang for by version and by os fixes bug 791737

https://github.com/mozilla/socorro/commit/f53b61129c2ab95847c0e702ec553abee62c2acf
Merge pull request #826 from ossreleasefeed/fix-hangs-in-cadu-791737

added options to choose browser hang or plugin hang for by version and by os fixes bug 791737

Comment 12

[Robert Kaiser]

Hmm, already pushed... And I was just about to say let's please ignore browser hangs...

Comment 13

[Schalk Neethling [:espressive]]

oops, should we do another one to remove the browser hangs option?

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d8bdf19e2d8b3ff02b5a8024d333e40b515b9061
partial revert of previous change, but keeping plugin hangs with appropriate type fixes bug 791737

https://github.com/mozilla/socorro/commit/f32fcf1ae3a848310bd765e76bdd6be323e3524f
Merge pull request #830 from ossreleasefeed/fix-hangs-in-cadu-791737

partial revert of previous change, but keeping plugin hangs with appropriate type fixes bug 791737

Comment 15

[Schalk Neethling [:espressive]]

Browser hangs are now always being filtered out so, for this the default 'Hang' options, has been replaces with 'Plugin Hang' and the appropriate value is being sent to the middleware.

Comment 16

[Matt Brandt [:mbrandt]]

Awesome .. thanks espressive.

Verified on stage - https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v[]=18.0a1&v[]=&v[]=&v[]=&hang_type=hang-p&os[]=Windows&os[]=Mac+OS+X&os[]=Linux&date_range_type=report&date_start=2012-09-03&date_end=2012-09-17&submit=Generate