791753 - Add top contributor list to Army of Awesome

Status: RESOLVED FIXED

(support.mozilla.org :: Army of Awesome, task, P3)

Description

[Kadir Topal [:atopal]]

Apparently the new designs for AoA include the new progress bar, but they don't show our top contributor list.

https://bug762255.bugzilla.mozilla.org/attachment.cgi?id=655868

Comment 1

[Swarnava Sengupta (:Swarnava)]

Any Updates?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

We need designs first, so this should probably drop to the following sprint.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Making this a 1pter assuming we can lift most of the code we were using before.

Comment 4

[Bram Pitoyo [:bram]]

Attachment: Army of Awesome with Top Contributors list

My proposal is to display the top contributors list only when user has signed in with his/her Twitter account.

The list will fill in the space left by the 1-2-3 steps, to the right of the page title.

Does this look like a good idea, or should the top contributors list appear at all times, even when user is not logged in?

Comment 5

[Kadir Topal [:atopal]]

Bram, can we reuse the old style here? Unlike the forum where we have the Karma system, we are using Twitter data on AoA and can display things like "contributions yesterday/last week, etc." including the Twitter avatar of people and the number of tweets. 

Unfortunately I can't find any screenshot of that old widget.

Madalina, regarding the question whether to restrict this to logged-in users: your call.

Comment 6

[Kadir Topal [:atopal]]

Talked to Madalina on IRC:

1. The top contributor data is to be shown to all users not just logged in users

2. Here is the data we'd need to have displayed: 
a. the number of contributions yesterday/last week, 
b. the number of tweets for each contributor and their avatar

Comment 7

[Bram Pitoyo [:bram]]

Attachment: Army of Awesome with Top Contributors list - design variations

Since comment 5 and comment 6 mentioned that the top contributors list needs to have various numbers in it, I’ve designed several layout variations.

There are six versions in this collection. The ones I like the best because they use space efficiently are #5 and #6 (sidebar).

If I have to pick one, it will be #6. This is the option where we allocate 9 column to the content, and 3 column to the top contributors sidebar.

Carving a bit of space for the sidebar is okay because a tweet can never be longer than 140 characters. In a 9-column, the whole 140-character will never take more space than 2 lines. This makes each tweet still short enough for contributors to be able to read and respond effectively, or scroll down if it’s irrelevant.

Comment 8

[Kadir Topal [:atopal]]

Thanks Bram, these look awesome! I totally agree, the sidebar makes sense here. Let's go with #6

Comment 9

[madalina]

I vote for #6 as well, thanks Bram, great stuff!

Comment 10

[Michael Cooper [:mythmon]]

Attachment: Screenshot of implementation.

I tweaked :bram's layout a bit, since the long names of some people weren't fitting quite right.

Pull request: https://github.com/mozilla/kitsune/pull/993

Comment 11

[Michael Cooper [:mythmon]]

Oh, and in the screenshot in the comment 10, a lot of the users have "0 Overall", which confuses me. I think (hope) that is just something weird on my setup and it will go away on stage.

Comment 12

[Michael Cooper [:mythmon]]

Landed in: https://github.com/mozilla/kitsune/commit/a00a7f18c18d36ecf4c12c01063afdb7e3b677c4

Comment 13

[Michael Cooper [:mythmon]]

Deployed to master just now.