Closed
Bug 791859
Opened 12 years ago
Closed 12 years ago
Incorrect order of operations in testHistoryTab's tearDown()
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
1.75 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Robocop's testHistoryTab.tearDown calls super.tearDown before executing code to cleanup database tables. All other Robocop tearDown methods call super.tearDown last (after test-specific tearDown code), since super.tearDown finishes activities and essential services like the asserter. I don't know of any problem being caused by the irregularity in testHistoryTab, but I want to change it so that it is consistent with all the other tests.
Assignee | ||
Comment 1•12 years ago
|
||
A patch you can review in 3.14159 seconds, or less!
Attachment #661947 -
Flags: review?(jmaher)
Comment 2•12 years ago
|
||
Comment on attachment 661947 [details] [diff] [review] change order of operations in testHistoryTab.tearDown oh nice
Attachment #661947 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3f2684bbc5
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bb3f2684bbc5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•