Time API: Clean up the usage comment in nsIDOMTimeManager (s/seconds/milliseconds)

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: airpingu, Assigned: airpingu)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

This is a super minor fix but the comments could be confusing to public clients.
Sorry guys... It seems it's not a good idea to use cloning bug. I'll watch out next time.
Assignee: nobody → clian
blocking-basecamp: + → ---
blocking-kilimanjaro: + → ---
No longer depends on: 791652, 791682, 714358, 790781, 790823, 791567
Priority: P1 → --
Whiteboard: [WebAPI:P1]
Posted patch Patch (obsolete) — Splinter Review
Just a minor nit but we need to correct that. Clients could wrongly use that and then the world will explode.
Attachment #662075 - Flags: review?(mounir)
Posted patch Patch 1.1 (obsolete) — Splinter Review
Striping out the trailing spaces as well.
Attachment #662075 - Attachment is obsolete: true
Attachment #662075 - Flags: review?(mounir)
Attachment #662078 - Flags: review?(mounir)
Comment on attachment 662078 [details] [diff] [review]
Patch 1.1

Review of attachment 662078 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #662078 - Flags: review?(mounir) → review+
Posted patch Patch 1.2 (obsolete) — Splinter Review
sr=mounir
Attachment #662078 - Attachment is obsolete: true
Attachment #662139 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Actually, Gene, I should have been more explicit about what "rs+" means.
It doesn't mean "sr+" but "rubber stamp" which basically means "this change doesn't need a proper review but I approve it so it can land". You can consider this as "r+". We mostly use that for typo fixes, comment changes, etc. where review doesn't make sense but having someone double-checking has to be part of the process.
Could you update the patch so the comment line doesn't mention sr but rs or r?
Sorry again for the confusion.
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Posted patch Patch 1.3Splinter Review
rs=mounir

Thanks for pointing this out! Good to learn that. :)
Attachment #662139 - Attachment is obsolete: true
Attachment #662154 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd720de0b57e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.