791962 - Time API: Clean up the usage comment in nsIDOMTimeManager (s/seconds/milliseconds)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

This is a super minor fix but the comments could be confusing to public clients.

Comment 1

[Gene Lian (I already quit Mozilla)]

Sorry guys... It seems it's not a good idea to use cloning bug. I'll watch out next time.

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Just a minor nit but we need to correct that. Clients could wrongly use that and then the world will explode.

Comment 3

[Gene Lian (I already quit Mozilla)]

Attachment: Patch 1.1

Striping out the trailing spaces as well.

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 662078 [details] [diff] [review]
Patch 1.1

Review of attachment 662078 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 5

[Gene Lian (I already quit Mozilla)]

Attachment: Patch 1.2

sr=mounir

Comment 6

[Mounir Lamouri (:mounir)]

Actually, Gene, I should have been more explicit about what "rs+" means.
It doesn't mean "sr+" but "rubber stamp" which basically means "this change doesn't need a proper review but I approve it so it can land". You can consider this as "r+". We mostly use that for typo fixes, comment changes, etc. where review doesn't make sense but having someone double-checking has to be part of the process.

Comment 7

[Mounir Lamouri (:mounir)]

Could you update the patch so the comment line doesn't mention sr but rs or r?
Sorry again for the confusion.

Comment 8

[Gene Lian (I already quit Mozilla)]

Attachment: Patch 1.3

rs=mounir

Thanks for pointing this out! Good to learn that. :)

Comment 9

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd720de0b57e

Comment 10

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/cd720de0b57e