Closed
Bug 791972
Opened 12 years ago
Closed 12 years ago
Background Images missing on firefox/new/ pages for locales, seems CDN related
Categories
(www.mozilla.org :: Legacy PHP system, defect)
www.mozilla.org
Legacy PHP system
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pascalc, Unassigned)
Details
(Whiteboard: [l10n-dogfooding])
Attachments
(1 file)
50.25 KB,
patch
|
rik
:
review+
|
Details | Diff | Splinter Review |
Anthony and myself noticed yesterday that the background illustration on firefox/new is not loaded on localized pages: http://www.mozilla.org/img/covehead/firefox/dbd-feature-bg.jpg Apparently the image is currently not loaded from mozilla.org but from the CDN which is not available: http://mozcom-cdn.mozilla.net/img/covehead/firefox/dbd-feature-bg.jpg Links to the CDN are activated in the PHP source code with the $config['static_prefix'] variable: background: #e04113 url(<?=$config['static_prefix'];?>/img/covehead/firefox/dbd-feature-bg.jpg) 50% 0 no-repeat That $config['static_prefix'] setting should be in includes/config.inc.php (which is not hosted on svn for security) I don't know if we currently use a CDN and if that value should be blank or not. If we are supposed to have the CDN activated, then I guess it is down, not available from Europe or the url in that config file is wrong. Thanks
Reporter | ||
Comment 1•12 years ago
|
||
I found out that there is an hardcoded cdn url in this css file: http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/style/covehead/home.css?annotate=101779#l24 so it looks like the CDN flag is not activated but the cdn used is down or no longer exists Also, a grep on the whole repo shows more hardcoded cdn urls that break less prominent pages, for example: http://www.mozilla.org/en-US/newsletter/welcome/index.html I'd like to push an immediate fix for our download pages and then I propose that we fix all the other hardcoded urls as a second step. Is that OK for you Rik? Also, we should probably check with IT if it is normal that the CDN url no longer works.
Comment 2•12 years ago
|
||
Pascal: Yes, please go ahead and fix this. Jake: I know we have bug 742890 for a new SSL-enabled CDN. But I was not aware the current CDN was being shut down. Was it intentional? Stephen, Raymond: I think this should have been detected by our utest scenarios. I'm not sure though since I don't know what our utest scenarios are. Can you shed a light on this?
Whiteboard: [l10n-dogfooding]
Reporter | ||
Comment 3•12 years ago
|
||
css fix in r109232 fixed on dev: https://www-dev.allizom.org/fr/firefox/new Pushed this fix to stage in r109233 and production in r109234
Reporter | ||
Comment 4•12 years ago
|
||
This is now fixed on prod : http://www.mozilla.org/fr/firefox/new Lowering the priority since it no longer affects our download page
Severity: major → normal
Comment 5•12 years ago
|
||
Oh dear... yes, we did take down the old mozcom-cdn.mozilla.net CDN recently. I knew it was already not in use in the main config files, so I believed it was no longer in use and pulled it. I apologize for not confirming first. FWIW setup of the new one is pretty much completed. The only thing left in bug 742890 is ironing out exactly what paths need to be accessible via CDN.
Reporter | ||
Comment 6•12 years ago
|
||
Anthony, here is a patch fixing all the hardcoded paths to the cdn on the php site. Jake, there are also references to videos-cdn.mozilla.net in the code, that one is still up, can you confirm that this one is still safe to use? Thanks
Attachment #663038 -
Flags: review?(anthony)
Comment 7•12 years ago
|
||
Yes, videos-cdn is safe isn't going anywhere anytime soon... that's used in a lot of places, and many of them are not tracked / known.
Reporter | ||
Comment 8•12 years ago
|
||
Thanks Jake
Comment 9•12 years ago
|
||
Hi Pascal, The uTest scenario we are currently running only focuses on the download buttons as the uTesters file mostly invalid bugs if you do not provide them with a clear outline as to what to test. I'll update our testcases to cover background images and other layout issues in our next iteration.
Reporter | ||
Comment 10•12 years ago
|
||
Thanks Raymond
Comment 11•12 years ago
|
||
Comment on attachment 663038 [details] [diff] [review] patch removing cdn references Review of attachment 663038 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks!
Attachment #663038 -
Flags: review?(anthony) → review+
Comment 12•12 years ago
|
||
(In reply to raymond [:retornam] from comment #9) > Hi Pascal, > The uTest scenario we are currently running only focuses on the download > buttons as the uTesters file mostly invalid bugs if you do not provide them > with a clear outline as to what to test. I'll update our testcases to cover > background images and other layout issues in our next iteration. Is there a bug that can be cc-ed on to track this?
Reporter | ||
Comment 13•12 years ago
|
||
pushed the patch to trunk in r109419, I can merge to stage + prod anytime, just ping me.
Comment 14•12 years ago
|
||
Go for it!
Reporter | ||
Comment 15•12 years ago
|
||
stage in r109422, prod in r109423
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•