Save users from polluting their dist/bin when building Lightning

RESOLVED FIXED in 2.1

Status

Calendar
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Lightning 1.7

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 662102 [details] [diff] [review]
Fix - v1

make -C objdir/calendar will start a build that inserts all sorts of lightning specific files into dist/bin. Especially new developers will get thrown off by this.

To counteract, I have done two things:

1. make -C objdir/calendar will call the calendar/lightning makefile instead
2. make -C objdir/calendar/base will set XPI_NAME too.
Attachment #662102 - Flags: review?(mbanner)
Comment on attachment 662102 [details] [diff] [review]
Fix - v1

Review of attachment 662102 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, I think this looks reasonable to do.
Attachment #662102 - Flags: review?(mbanner) → review+
Assignee: nobody → philipp
(Assignee)

Comment 2

5 years ago
Pushed to comm-central changeset 117e2e975798
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1
You need to log in before you can comment on or make changes to this bug.