Closed
Bug 791989
Opened 13 years ago
Closed 13 years ago
FlagDefaultRequestee link shouldn't be visible if a default requestee has not be specified
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
Details
Attachments
(1 file)
|
2.11 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
FlagDefaultRequestee link shouldn't be visible if a default requestee has not be specified.
currently it's always visible, and inserts "undefined".
this only happens if one of the other flags on the bug has a default requestee set.
Assignee: nobody → glob
fixes showing 'default requestee' when not set, also fixes a javascript error for flags which don't allow a requestee, and fixes the width of the autocomplete field.
Attachment #662153 -
Flags: review?(dkl)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 662153 [details] [diff] [review]
patch v1
Review of attachment 662153 [details] [diff] [review]:
-----------------------------------------------------------------
Can't believe I missed that :( Anyway, looks great and works as well. r=dkl
Attachment #662153 -
Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/FlagDefaultRequestee/template/en/default/flag/default_requestees.html.tmpl
Committed revision 8333.
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/FlagDefaultRequestee/template/en/default/flag/default_requestees.html.tmpl
Committed revision 8352.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Extensions: Other → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•