792005 - Don't throw when setting a named property in non-strict mode

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The spec says:

> If /creating/ is false and /O/ does not implement an interface
> with a named property setter, then Reject.

(<http://dev.w3.org/2006/webapi/WebIDL/#defineownproperty>, step 3.2.1), and

> The term “Reject” is used in the same sense as that defined in
> ECMA-262, namely, to mean “If Throw is true, then throw a
> TypeError exception, otherwise return false”. 

but we do

"  if (found) {\n"
"    return ThrowErrorMessage(cx, MSG_NO_PROPERTY_SETTER, \"%s\");\n" +
"  }\n" +

i.e, throw in all modes

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is worksforme on tip.  Testcase:

  data:text/html,<img name="foo">

and then in the console:

  (function() { "use strict"; document.images.foo = 5 })() /* throws */
  document.images.foo = 5 /* does not throw */