If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Security Coverage: Inspect dom/workers/WorkerPrivate.cpp and dom/workers/WorkerScope.cpp

RESOLVED INCOMPLETE

Status

()

Core
DOM: Workers
RESOLVED INCOMPLETE
5 years ago
2 years ago

People

(Reporter: decoder, Unassigned)

Tracking

(Blocks: 1 bug, {sec-audit})

Trunk
x86_64
Linux
sec-audit
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
According to our analysis, the files dom/workers/WorkerPrivate.cpp and dom/workers/WorkerScope.cpp have untested portions of code/functions while the subsystem has been patched one or more times in the last 6 months due to security problems. The coverage data for these files (from a try run with our main test suites) is here:

http://people.mozilla.org/~choller/coverage/mc-tests-all-20120903/dom/workers/WorkerPrivate.cpp.gcov.html
http://people.mozilla.org/~choller/coverage/mc-tests-all-20120903/dom/workers/WorkerScope.cpp.gcov.html

(Assertions, warnings and errors like out-of-memory conditions or those that cannot be triggered through content should be ignored).

File specific comments per file:

dom/workers/WorkerPrivate.cpp: code around lines 287, 1990, 2377 and 3635
dom/workers/WorkerScope.cpp: functions in lines 140, 306, 710 and 1003

Please add appropriate tests and/or check the untested portions of code if it is possible and reasonable.
WorkerPrivate.cpp

287: We need a test for postMessaging a file from a worker back to the main thread
1990: I think this can only be hit if the worker and the main thread race in just the right way.
2377: This needs a test (we need to figure out what it does too :-P)
3635: Do we not have tests for string timeouts?  That's bad.

WorkerScope.cpp

140: We need a test that reads back event listeners
306: Ditto
710: ...
1003: I think this is dead code.
Per discussion with decoder, these bugs are not likely to be relevant at this point (and the reports themselves are long gone). Any further work is better suited for new bugs at this point.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: testcase-wanted
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.