792015 - B2G desktop build does not have a homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Sounds like the new mechanism to prevent race introduce one :)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 2

[Etienne Segonzac (:etienne)]

Looks like the patch is not helping :/

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Etienne Segonzac from comment #2)
> Looks like the patch is not helping :/

Sigh. Works for me :(

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 662133 [details] [diff] [review]
Patch

Review of attachment 662133 [details] [diff] [review]:
-----------------------------------------------------------------

Doing that just delays loading webapps.jsm but gives no guarantee that the activities are registered when you fire webapps-registry-ready

Comment 5

[[:fabrice] Fabrice Desré]

Attachment: patch

This patch makes sure we actually registered activities before firing webapps-registry-ready, also refactors the startup path to be ready for bug 787439

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: patch v2

In this version I also moved loading webapps.jsm when we fire 'contentstart' to be sure that an extremely slow loading system app would not lose a race against the webapps registry.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 662358 [details] [diff] [review]
patch v2

Review of attachment 662358 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but I would like a local variable.

::: dom/apps/src/Webapps.jsm
@@ +189,5 @@
> +              }
> +            }
> +            // XXXX once bug 758269 is ready, revoke perms for this app
> +            // installPermissions(this.webapps[id].localId);
> +          }

What about making a local variable of this.webapps[id] ?

Comment 8

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7276747d5260

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8c813f40ea4e