B2G desktop build does not have a homescreen

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vingtetun, Assigned: fabrice)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Sounds like the new mechanism to prevent race introduce one :)
Created attachment 662133 [details] [diff] [review]
Patch
Assignee: nobody → 21
Status: NEW → ASSIGNED
Attachment #662133 - Flags: review?(fabrice)
Looks like the patch is not helping :/
(In reply to Etienne Segonzac from comment #2)
> Looks like the patch is not helping :/

Sigh. Works for me :(
(Assignee)

Comment 4

6 years ago
Comment on attachment 662133 [details] [diff] [review]
Patch

Review of attachment 662133 [details] [diff] [review]:
-----------------------------------------------------------------

Doing that just delays loading webapps.jsm but gives no guarantee that the activities are registered when you fire webapps-registry-ready
Attachment #662133 - Flags: review?(fabrice) → review-
(Assignee)

Comment 5

6 years ago
Created attachment 662201 [details] [diff] [review]
patch

This patch makes sure we actually registered activities before firing webapps-registry-ready, also refactors the startup path to be ready for bug 787439
Assignee: 21 → fabrice
Attachment #662133 - Attachment is obsolete: true
Attachment #662201 - Flags: review?(21)
(Assignee)

Comment 6

6 years ago
Created attachment 662358 [details] [diff] [review]
patch v2

In this version I also moved loading webapps.jsm when we fire 'contentstart' to be sure that an extremely slow loading system app would not lose a race against the webapps registry.
Attachment #662201 - Attachment is obsolete: true
Attachment #662201 - Flags: review?(21)
Attachment #662358 - Flags: review?(21)
Comment on attachment 662358 [details] [diff] [review]
patch v2

Review of attachment 662358 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but I would like a local variable.

::: dom/apps/src/Webapps.jsm
@@ +189,5 @@
> +              }
> +            }
> +            // XXXX once bug 758269 is ready, revoke perms for this app
> +            // installPermissions(this.webapps[id].localId);
> +          }

What about making a local variable of this.webapps[id] ?
Attachment #662358 - Flags: review?(21) → review+
https://hg.mozilla.org/mozilla-central/rev/8c813f40ea4e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.