792062 - Make the tabNavigated notification reusable by the Web Console

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Mihai Sucan [:msucan]]

We need tabNavigated to fire at the start and end of a location change.

For details see bug 768096 comment 36.

Comment 1

[Mihai Sucan [:msucan]]

First patch is here:
https://github.com/joewalker/devtools-window/pull/320

Comment 2

[Mihai Sucan [:msucan]]

Attachment: proposed patch

This is the patch from the pull request.

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=b1482f94a839

Please let me know if further changes are needed. Thank you!

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Testing Fennec almost everything seems to work OK, except the following message:

Connection timeout. Check the Error Console on both ends for potential error messages. Reopen the Web Console to try again.

This appears in the web console a few seconds after connecting to Fennec. It also appears after connecting a patched web console to an unpatched Fennec nightly, so I'm guessing the frontend code is at fault. Nothing is present in the browser's error console and I don't see anything relevant in adb logcat, but I might need to flip some prefs there. Any idea where to look next?

Comment 4

[Mihai Sucan [:msucan]]

Connection timeout message shows only if WCCP_connect doesn't finish. It attaches to a tab and to a console actor. Maybe one of these fail?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Protocol log

I see both tabAttached and startedListeners responses. And the console seems to work fine despite that message (autocompletion, evaluation, etc.).

Comment 6

[Mihai Sucan [:msucan]]

Thanks. I'll look into this. Working on building Fennec here.

Comment 7

[Mihai Sucan [:msucan]]

Attachment: fixed patch

Fixed it. Should work now with Fennec. Tested on my system with B2G Desktop and Fennec on Android (emulator). I missed a callback.

Please double-check and also verify that the debugger is unaffected.

I'd like to land this patch ASAP. Thank you!

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 693063 [details] [diff] [review]
fixed patch

Review of attachment 693063 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, seems fixed now. Let's land this puppy!

Comment 9

[Mihai Sucan [:msucan]]

Landed:
https://hg.mozilla.org/integration/fx-team/rev/8ba98799b6bb

Thank you!

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/8ba98799b6bb