Make the tabNavigated notification reusable by the Web Console

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

Trunk
Firefox 20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We need tabNavigated to fire at the start and end of a location change.

For details see bug 768096 comment 36.
Priority: -- → P3
(Assignee)

Comment 1

5 years ago
First patch is here:
https://github.com/joewalker/devtools-window/pull/320
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 691374 [details] [diff] [review]
proposed patch

This is the patch from the pull request.

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=b1482f94a839

Please let me know if further changes are needed. Thank you!
Attachment #691374 - Flags: review?(past)
Testing Fennec almost everything seems to work OK, except the following message:

Connection timeout. Check the Error Console on both ends for potential error messages. Reopen the Web Console to try again.

This appears in the web console a few seconds after connecting to Fennec. It also appears after connecting a patched web console to an unpatched Fennec nightly, so I'm guessing the frontend code is at fault. Nothing is present in the browser's error console and I don't see anything relevant in adb logcat, but I might need to flip some prefs there. Any idea where to look next?
(Assignee)

Comment 4

5 years ago
Connection timeout message shows only if WCCP_connect doesn't finish. It attaches to a tab and to a console actor. Maybe one of these fail?
Created attachment 691387 [details]
Protocol log

I see both tabAttached and startedListeners responses. And the console seems to work fine despite that message (autocompletion, evaluation, etc.).
(Assignee)

Comment 6

5 years ago
Thanks. I'll look into this. Working on building Fennec here.
(Assignee)

Comment 7

5 years ago
Created attachment 693063 [details] [diff] [review]
fixed patch

Fixed it. Should work now with Fennec. Tested on my system with B2G Desktop and Fennec on Android (emulator). I missed a callback.

Please double-check and also verify that the debugger is unaffected.

I'd like to land this patch ASAP. Thank you!
Attachment #691374 - Attachment is obsolete: true
Attachment #691374 - Flags: review?(past)
Attachment #693063 - Flags: review?(past)
Comment on attachment 693063 [details] [diff] [review]
fixed patch

Review of attachment 693063 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, seems fixed now. Let's land this puppy!
Attachment #693063 - Flags: review?(past) → review+
(Assignee)

Comment 9

5 years ago
Landed:
https://hg.mozilla.org/integration/fx-team/rev/8ba98799b6bb

Thank you!
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8ba98799b6bb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.