We need tabNavigated to fire at the start and end of a location change.
For details see bug 768096 comment 36.
First patch is here:
Created attachment 691374 [details] [diff] [review]
This is the patch from the pull request.
Please let me know if further changes are needed. Thank you!
Testing Fennec almost everything seems to work OK, except the following message:
Connection timeout. Check the Error Console on both ends for potential error messages. Reopen the Web Console to try again.
This appears in the web console a few seconds after connecting to Fennec. It also appears after connecting a patched web console to an unpatched Fennec nightly, so I'm guessing the frontend code is at fault. Nothing is present in the browser's error console and I don't see anything relevant in adb logcat, but I might need to flip some prefs there. Any idea where to look next?
Connection timeout message shows only if WCCP_connect doesn't finish. It attaches to a tab and to a console actor. Maybe one of these fail?
Created attachment 691387 [details]
I see both tabAttached and startedListeners responses. And the console seems to work fine despite that message (autocompletion, evaluation, etc.).
Thanks. I'll look into this. Working on building Fennec here.
Created attachment 693063 [details] [diff] [review]
Fixed it. Should work now with Fennec. Tested on my system with B2G Desktop and Fennec on Android (emulator). I missed a callback.
Please double-check and also verify that the debugger is unaffected.
I'd like to land this patch ASAP. Thank you!
Comment on attachment 693063 [details] [diff] [review]
Review of attachment 693063 [details] [diff] [review]:
Yep, seems fixed now. Let's land this puppy!