Closed Bug 792164 Opened 8 years ago Closed 7 years ago

add mozdevice to virtualenv in m-c

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: k0scist, Assigned: k0scist)

Details

Attachments

(1 file)

I have no idea why but we dont add mozdevice to the virtualenv in m-c:
https://mxr.mozilla.org/mozilla-central/source/build/virtualenv/packages.txt

We should add it.
As far as I'm concerned, everything in mozbase should be in the virtualenv. It doesn't hurt.
(In reply to Jeff Hammel [:jhammel] from comment #0)
> I have no idea why but we dont add mozdevice to the virtualenv in m-c:
> https://mxr.mozilla.org/mozilla-central/source/build/virtualenv/packages.txt
> 
> We should add it.

From what I understand on irc, this would allow us to stop copying/importing copies of devicemanager inside the tree.[1] Instead we could just import mozdevice from the tests and be done with it. That would be nice.

[1] http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/Makefile.in#63
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/Makefile.in#53
Attached patch add .pthSplinter Review
Attachment #667696 - Flags: review?(gps)
Comment on attachment 667696 [details] [diff] [review]
add .pth

Review of attachment 667696 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #667696 - Flags: review?(gps) → review+
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=365a69a47bde

It would be nice to put all of mozbase here;  I suppose I'll likely do that someday
Assignee: nobody → jhammel
https://hg.mozilla.org/mozilla-central/rev/28f8ca089e9c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.