Closed Bug 792201 Opened 12 years ago Closed 12 years ago

move pushed snippets to a different directory

Categories

(Release Engineering :: Release Automation: Other, defect)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: mozilla)

References

Details

Attachments

(3 files)

move pushed dir
1.21 KB, patch
nthomas
: review+
Details | Diff | Splinter Review
as checked in
2.13 KB, patch
mozilla
: checked-in+
Details | Diff | Splinter Review
fix pushsnip
841 bytes, patch
bhearsum
: review+
mozilla
: checked-in+
Details | Diff | Splinter Review 
When pushsnip finishes running successfully it should move the pushed directory somewhere else (a 'pushed' subdirectory? /opt/aus2/snippets/pushed?). This would do two things:
1) Help unclutter /opt/aus2/snippets/staging
2) Help avoid accidentally repushing snippets that were already pushed
Attached patch move pushed dir — — Splinter Review 
Should we put the .time files there too, or leave them?
Attachment #662303 - Flags: review?(bhearsum)
Attachment #662303 - Flags: review?(bhearsum) → review?(nthomas)
Comment on attachment 662303 [details] [diff] [review]
move pushed dir

Looks fine. I'd say it makes sense to put the .time files in PUSHED_DIR too, feel free to make that change on checkin.
Attachment #662303 - Flags: review?(nthomas) → review+
Attached patch as checked in — — Splinter Review 
Checking in pushsnip;
/cvsroot/mozilla/tools/release/bin/pushsnip,v  <--  pushsnip
new revision: 1.9; previous revision: 1.8
done
Attachment #662345 - Flags: checked-in+
Updated aus3-staging:~ffxbld/bin .
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Unfortunately, this broke pushsnip:
         446 100%    5.97kB/s    0:00:00 (xfer#40060, to-check=0/97678)

sent 22957641 bytes  received 822880 bytes  26003.85 bytes/sec
total size is 18841404  speedup is 0.79
mv: cannot stat `Firefox-16.0b4-build1-test': No such file or directory

Wrong cwd / should be using full path, maybe?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: nobody → aki
Attached patch fix pushsnip — — Splinter Review 

        Attachment #663053 -
        Flags: review?(bhearsum)

    
  

        Attachment #663053 -
        Flags: review?(bhearsum) → review+

    
    

    
  
Comment on attachment 663053 [details] [diff] [review]
fix pushsnip

Checking in pushsnip;
/cvsroot/mozilla/tools/release/bin/pushsnip,v  <--  pushsnip
new revision: 1.10; previous revision: 1.9
done

        Attachment #663053 -
        Flags: checked-in+

    
  
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED

    
    

    
  
Updated aus3-staging:~ffxbld/bin after cvs-mirror updated.

    
    

    
  
I moved all of the already pushed directory from staging/ into pushed/. Hooray for having a clean staging/ directory!

    
    

    
  
Worked fine for the beta channel push. Thanks!
Depends on: 794335
Product: mozilla.org → Release Engineering

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: