move pushed snippets to a different directory

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

When pushsnip finishes running successfully it should move the pushed directory somewhere else (a 'pushed' subdirectory? /opt/aus2/snippets/pushed?). This would do two things:
1) Help unclutter /opt/aus2/snippets/staging
2) Help avoid accidentally repushing snippets that were already pushed
(Assignee)

Comment 1

6 years ago
Created attachment 662303 [details] [diff] [review]
move pushed dir

Should we put the .time files there too, or leave them?
Attachment #662303 - Flags: review?(bhearsum)
(Assignee)

Updated

6 years ago
Attachment #662303 - Flags: review?(bhearsum) → review?(nthomas)
Comment on attachment 662303 [details] [diff] [review]
move pushed dir

Looks fine. I'd say it makes sense to put the .time files in PUSHED_DIR too, feel free to make that change on checkin.
Attachment #662303 - Flags: review?(nthomas) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 662345 [details] [diff] [review]
as checked in

Checking in pushsnip;
/cvsroot/mozilla/tools/release/bin/pushsnip,v  <--  pushsnip
new revision: 1.9; previous revision: 1.8
done
Attachment #662345 - Flags: checked-in+
(Assignee)

Comment 4

6 years ago
Updated aus3-staging:~ffxbld/bin .
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Unfortunately, this broke pushsnip:
         446 100%    5.97kB/s    0:00:00 (xfer#40060, to-check=0/97678)

sent 22957641 bytes  received 822880 bytes  26003.85 bytes/sec
total size is 18841404  speedup is 0.79
mv: cannot stat `Firefox-16.0b4-build1-test': No such file or directory

Wrong cwd / should be using full path, maybe?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

6 years ago
Assignee: nobody → aki
(Assignee)

Comment 6

6 years ago
Created attachment 663053 [details] [diff] [review]
fix pushsnip
Attachment #663053 - Flags: review?(bhearsum)
(Reporter)

Updated

6 years ago
Attachment #663053 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 7

6 years ago
Comment on attachment 663053 [details] [diff] [review]
fix pushsnip

Checking in pushsnip;
/cvsroot/mozilla/tools/release/bin/pushsnip,v  <--  pushsnip
new revision: 1.10; previous revision: 1.9
done
Attachment #663053 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

6 years ago
Updated aus3-staging:~ffxbld/bin after cvs-mirror updated.
I moved all of the already pushed directory from staging/ into pushed/. Hooray for having a clean staging/ directory!
Worked fine for the beta channel push. Thanks!
Depends on: 794335
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.