Closed
Bug 792202
Opened 13 years ago
Closed 13 years ago
mozboot not compatible with Python 2.6
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: gps, Assigned: gps)
Details
Attachments
(1 file)
|
5.45 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
I performed a fresh install of OS X 10.6 and tried to use mozboot and it failed hard. It appears optparse doesn't accept unicode strings as argument names. Additionally, I got an error importing bootstrap.py.
This is chuck full of fail. Hopefully I'll have a patch up soon...
|
Assignee | |
Comment 1•13 years ago
|
||
Necessary evil makes me feel dirty.
|
||
Comment 2•13 years ago
|
||
Realistically, I think supporting python 2.6, 2.7, and 3.x is HARD for software of any size. Personally, I would concentrate on 2.6 and 2.7 until we require 2.7. Supporing 2.7 and 3.x is much more reasonable.
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 662315 [details] [diff] [review]
Python 2.6.1 compatibility, v1
+ """Implementation of subprocess.check_output for Pythons missing is."""
Typo?
other than that, wfm
Attachment #662315 -
Flags: review?(jhammel) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e2f161ca30bc
Thanks for the quick review!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•