792224 - add explicit test for worker.js's detach event on the content side

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

If there is a test already then I missed it.

Comment 1

[willmarquardt]

In the content script, you can do self.on("detach", function() {}); though it is not mentioned in the documentation. 

Is that what you mean?

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to willmarquardt from comment #1)
> In the content script, you can do self.on("detach", function() {}); though
> it is not mentioned in the documentation. 
> 
> Is that what you mean?

Yes that is what I mean, I'm pretty sure that due to a bug this does not work at the moment, and if it ever worked then there were no tests for it, which is what allowed it to regress.

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1414

Erik, this is similar to your test for bug 964118, only simpler..

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e165531da5c0786d1cba13f94fd49d3cd216ed82
bug 792224 - test onDetach event in contentScript

https://github.com/mozilla/addon-sdk/commit/5db6e2a9204b8cac4dc24c2da2ceff5313c18ac9
Merge pull request #1414 from zombie/792224-ondetach-tests

bug 792224 - test onDetach event in contentScript r=@erikvold